dirfd: Move AC_LIBOBJ invocations to module description.

* m4/dirfd.m4 (gl_PREREQ_DIRFD): New macro, extracted from
gl_FUNC_DIRFD.
(gl_FUNC_DIRFD): Move AC_LIBOBJ and gl_PREREQ_DIRFD invocations from
here...
* modules/dirfd (configure.ac): ... to here.
(Depends-on): Fix condition.

diff --git a/ChangeLog b/ChangeLog
index 8aa527e6e37ae9835f9a1d2e3ab7f4463588d2a5..e64950a2b64b67ccc1ee2c2e40229f3ff2497048 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2011-05-05  Bruno Haible  <bruno@clisp.org>
+
+       dirfd: Move AC_LIBOBJ invocations to module description.
+       * m4/dirfd.m4 (gl_PREREQ_DIRFD): New macro, extracted from
+       gl_FUNC_DIRFD.
+       (gl_FUNC_DIRFD): Move AC_LIBOBJ and gl_PREREQ_DIRFD invocations from
+       here...
+       * modules/dirfd (configure.ac): ... to here.
+       (Depends-on): Fix condition.
+
 2011-05-05  Bruno Haible  <bruno@clisp.org>
 
        chown: Respect rules for use of AC_LIBOBJ.

diff --git a/m4/dirfd.m4 b/m4/dirfd.m4
index f401f6ced4846fb5cc7ea3fa9aab74e3a392bd83..62dcd8830af0aef5cc7c2e49f5c6edc91b241270 100644 (file)
--- a/m4/dirfd.m4
+++ b/m4/dirfd.m4
@@ -1,4 +1,4 @@
-# serial 20   -*- Autoconf -*-
+# serial 21   -*- Autoconf -*-
 
 dnl Find out how to get the file descriptor associated with an open DIR*.
 
@@ -36,45 +36,48 @@ AC_DEFUN([gl_FUNC_DIRFD],
        gl_cv_func_dirfd_macro=no)])
 
   # Use the replacement only if we have no function or macro with that name.
-  if test $ac_cv_func_dirfd,$gl_cv_func_dirfd_macro = no,no; then
+  if test $ac_cv_func_dirfd = no && test $gl_cv_func_dirfd_macro = no; then
     if test $ac_cv_have_decl_dirfd = yes; then
       # If the system declares dirfd already, let's declare rpl_dirfd instead.
       REPLACE_DIRFD=1
     fi
-    AC_LIBOBJ([dirfd])
-    AC_CACHE_CHECK(
-              [how to get the file descriptor associated with an open DIR*],
-                   gl_cv_sys_dir_fd_member_name,
-      [
-        dirfd_save_CFLAGS=$CFLAGS
-        for ac_expr in d_fd dd_fd; do
+  fi
+])
 
-          CFLAGS="$CFLAGS -DDIR_FD_MEMBER_NAME=$ac_expr"
-          AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
-             #include <sys/types.h>
-             #include <dirent.h>]],
-            [[DIR *dir_p = opendir("."); (void) dir_p->DIR_FD_MEMBER_NAME;]])],
-            [dir_fd_found=yes]
-          )
-          CFLAGS=$dirfd_save_CFLAGS
-          test "$dir_fd_found" = yes && break
-        done
-        test "$dir_fd_found" = yes || ac_expr=no_such_member
+dnl Prerequisites of lib/dirfd.c.
+AC_DEFUN([gl_PREREQ_DIRFD],
+[
+  AC_CACHE_CHECK([how to get the file descriptor associated with an open DIR*],
+                 [gl_cv_sys_dir_fd_member_name],
+    [
+      dirfd_save_CFLAGS=$CFLAGS
+      for ac_expr in d_fd dd_fd; do
 
-        gl_cv_sys_dir_fd_member_name=$ac_expr
-      ]
-    )
-    if test $gl_cv_sys_dir_fd_member_name != no_such_member; then
-      AC_DEFINE_UNQUOTED([DIR_FD_MEMBER_NAME],
-        $gl_cv_sys_dir_fd_member_name,
-        [the name of the file descriptor member of DIR])
-    fi
-    AH_VERBATIM(DIR_TO_FD,
-                [#ifdef DIR_FD_MEMBER_NAME
+        CFLAGS="$CFLAGS -DDIR_FD_MEMBER_NAME=$ac_expr"
+        AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+           #include <sys/types.h>
+           #include <dirent.h>]],
+          [[DIR *dir_p = opendir("."); (void) dir_p->DIR_FD_MEMBER_NAME;]])],
+          [dir_fd_found=yes]
+        )
+        CFLAGS=$dirfd_save_CFLAGS
+        test "$dir_fd_found" = yes && break
+      done
+      test "$dir_fd_found" = yes || ac_expr=no_such_member
+
+      gl_cv_sys_dir_fd_member_name=$ac_expr
+    ]
+  )
+  if test $gl_cv_sys_dir_fd_member_name != no_such_member; then
+    AC_DEFINE_UNQUOTED([DIR_FD_MEMBER_NAME],
+      [$gl_cv_sys_dir_fd_member_name],
+      [the name of the file descriptor member of DIR])
+  fi
+  AH_VERBATIM([DIR_TO_FD],
+              [#ifdef DIR_FD_MEMBER_NAME
 # define DIR_TO_FD(Dir_p) ((Dir_p)->DIR_FD_MEMBER_NAME)
 #else
 # define DIR_TO_FD(Dir_p) -1
 #endif
 ])
-  fi
 ])

diff --git a/modules/dirfd b/modules/dirfd
index 8410f38d72be2cef2182183ddd6f0fbcf3ebc3d6..1c6d26fa338945d35df844b1fa414556e3f38e0a 100644 (file)
--- a/modules/dirfd
+++ b/modules/dirfd
@@ -8,10 +8,14 @@ m4/dirfd.m4
 Depends-on:
 dirent
 extensions
-errno           [test $ac_cv_have_decl_dirfd = no || test $REPLACE_DIRFD = 1]
+errno           [test $ac_cv_func_dirfd = no && test $gl_cv_func_dirfd_macro = no]
 
 configure.ac:
 gl_FUNC_DIRFD
+if test $ac_cv_func_dirfd = no && test $gl_cv_func_dirfd_macro = no; then
+  AC_LIBOBJ([dirfd])
+  gl_PREREQ_DIRFD
+fi
 gl_DIRENT_MODULE_INDICATOR([dirfd])
 
 Makefile.am: