Fix side effects from tests-related modules.

diff --git a/ChangeLog b/ChangeLog
index 6ff91cb8850657b95441e7ed3ccdac09f69b57a6..8c80d6a9c9c935b67ed7f93930146c495fec14a8 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,34 @@
+2010-04-08  Bruno Haible  <bruno@clisp.org>
+
+       Fix side effects from tests-related modules.
+       * modules/dprintf-posix (Comment): New section.
+       * modules/fprintf-posix (Comment): Likewise.
+       * modules/obstack-printf-posix (Comment): Likewise.
+       * modules/printf-posix (Comment): Likewise.
+       * modules/snprintf-posix (Comment): Likewise.
+       * modules/sprintf-posix (Comment): Likewise.
+       * modules/vasnprintf-posix (Comment): Likewise.
+       * modules/vasprintf-posix (Comment): Likewise.
+       * modules/vdprintf-posix (Comment): Likewise.
+       * modules/vfprintf-posix (Comment): Likewise.
+       * modules/vprintf-posix (Comment): Likewise.
+       * modules/vsnprintf-posix (Comment): Likewise.
+       * modules/vsprintf-posix (Comment): Likewise.
+       * modules/xprintf-posix (Comment): Likewise.
+       * modules/xvasprintf-posix (Comment): Likewise.
+       * modules/ceilf-tests (Depends-on): Remove fprintf-posix.
+       * modules/floorf-tests (Depends-on): Likewise.
+       * modules/round-tests (Depends-on): Likewise.
+       * modules/roundf-tests (Depends-on): Likewise.
+       * modules/trunc-tests (Depends-on): Likewise.
+       * modules/truncf-tests (Depends-on): Likewise.
+       * tests/test-ceilf2.c (check): Don't invoke fprintf if the
+       'fprintf-posix' module is not present.
+       * tests/test-floorf2.c (check): Likewise.
+       * tests/test-trunc2.c (check): Likewise.
+       * tests/test-truncf2.c (check): Likewise.
+       * tests/test-round2.c (equal): Likewise.
+
 2010-04-07  Karl Berry  <karl@gnu.org>
 
        * config/srclist.txt,

diff --git a/modules/ceilf-tests b/modules/ceilf-tests
index 9462b06f45e8a7096fa1d7251a64d06c8d882a64..09c9c7816bbef30cbef4e58b856bad9dba985a07 100644 (file)
--- a/modules/ceilf-tests
+++ b/modules/ceilf-tests
@@ -10,7 +10,6 @@ float
 isnanf-nolibm
 stdbool
 stdint
-fprintf-posix
 
 configure.ac:
 

diff --git a/modules/dprintf-posix b/modules/dprintf-posix
index 1f4b85c1a93fd5c78e52a70a61ac68c02d373293..19a471807e9e1099639e97a380a5e55e8cb2f0c4 100644 (file)
--- a/modules/dprintf-posix
+++ b/modules/dprintf-posix
@@ -2,6 +2,12 @@ Description:
 POSIX compatible dprintf() function: print formatted output to a file
 descriptor
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 m4/dprintf-posix.m4
 m4/printf.m4

diff --git a/modules/floorf-tests b/modules/floorf-tests
index ffe6a9951e6b4d1afd006523c203a0d900db7f81..64b4e3c31eea8139fa095b7a91d0663c1c42d8be 100644 (file)
--- a/modules/floorf-tests
+++ b/modules/floorf-tests
@@ -10,7 +10,6 @@ float
 isnanf-nolibm
 stdbool
 stdint
-fprintf-posix
 
 configure.ac:
 

diff --git a/modules/fprintf-posix b/modules/fprintf-posix
index 2f22ebda8df665c61cff4b2b30aae0e4314cf961..be2b010dd812d4fe45f5ad30b76a0b791b679489 100644 (file)
--- a/modules/fprintf-posix
+++ b/modules/fprintf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX compatible fprintf() function: print formatted output to a stream
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 lib/fprintf.c
 m4/fprintf-posix.m4

diff --git a/modules/obstack-printf-posix b/modules/obstack-printf-posix
index eb7bef530fff9b0eff54d952517eb8e5617c6de2..306a3df30b58807192f2eb959c8edd757f984d41 100644 (file)
--- a/modules/obstack-printf-posix
+++ b/modules/obstack-printf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX formatted printing into an obstack.
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 m4/obstack-printf.m4
 m4/obstack-printf-posix.m4

diff --git a/modules/printf-posix b/modules/printf-posix
index b690c729e008ae998232ebdd04c4914254115150..b9884f4a222a2dc32a7590f61c091f340b5e2734 100644 (file)
--- a/modules/printf-posix
+++ b/modules/printf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX compatible printf() function: print formatted output to standard output
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 lib/printf.c
 m4/printf-posix-rpl.m4

diff --git a/modules/round-tests b/modules/round-tests
index 28b0defef8efa903068c69a6ec4c618866f66c93..b52890cd4b5d656e8c718578e05102cab7ad7da2 100644 (file)
--- a/modules/round-tests
+++ b/modules/round-tests
@@ -9,7 +9,6 @@ Depends-on:
 isnand-nolibm
 stdbool
 stdint
-fprintf-posix
 verify
 
 configure.ac:

diff --git a/modules/roundf-tests b/modules/roundf-tests
index 82ff3b74ca232592c7d7ad9642d7ae02694ee4a4..8d99ab91a283834db0845a24ee9172704f54c3c9 100644 (file)
--- a/modules/roundf-tests
+++ b/modules/roundf-tests
@@ -12,7 +12,6 @@ floorf
 isnanf-nolibm
 stdbool
 stdint
-fprintf-posix
 verify
 
 configure.ac:

diff --git a/modules/snprintf-posix b/modules/snprintf-posix
index 28c8fe37e0ce7afc18524fac466f053f8d19993e..16b38b7dde1fb6d2409bdeba5ed0f194cf154aed 100644 (file)
--- a/modules/snprintf-posix
+++ b/modules/snprintf-posix
@@ -2,6 +2,12 @@ Description:
 POSIX compatible snprintf() function: print formatted output to a fixed length
 string
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 m4/snprintf-posix.m4
 m4/printf.m4

diff --git a/modules/sprintf-posix b/modules/sprintf-posix
index e432bd882ea38703cea2af4452dc338a11ecb363..b5f02f6aafbbff5f5145880f28fd5e70abe4a77f 100644 (file)
--- a/modules/sprintf-posix
+++ b/modules/sprintf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX compatible sprintf() function: print formatted output to a string
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 lib/sprintf.c
 m4/sprintf-posix.m4

diff --git a/modules/trunc-tests b/modules/trunc-tests
index 3f84affcd0e56142557c0e408b4ca5aa822172b3..ce1e9799649bc14594d258957a09e35d70f5a4e7 100644 (file)
--- a/modules/trunc-tests
+++ b/modules/trunc-tests
@@ -10,7 +10,6 @@ float
 isnand-nolibm
 stdbool
 stdint
-fprintf-posix
 
 configure.ac:
 

diff --git a/modules/truncf-tests b/modules/truncf-tests
index a2b93202dadcb431d15ef80c00b2706185f8abca..746950d14bf7cd27cf9a142fd77405543cd7cc6d 100644 (file)
--- a/modules/truncf-tests
+++ b/modules/truncf-tests
@@ -10,7 +10,6 @@ float
 isnanf-nolibm
 stdbool
 stdint
-fprintf-posix
 
 configure.ac:
 

diff --git a/modules/vasnprintf-posix b/modules/vasnprintf-posix
index 2e47814fc21242fc2bc9bad54495b8133417c3aa..6a6177abb92147a44ed04d0630f124deb2d3b926 100644 (file)
--- a/modules/vasnprintf-posix
+++ b/modules/vasnprintf-posix
@@ -2,6 +2,12 @@ Description:
 POSIX compatible vsprintf with automatic memory allocation and bounded output
 size.
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 m4/vasnprintf-posix.m4
 m4/printf.m4

diff --git a/modules/vasprintf-posix b/modules/vasprintf-posix
index 1fc33857c007ae8fd8ed289f481790ee666ca515..5e9050689aa2bef67cdcb24291291f43f30a853e 100644 (file)
--- a/modules/vasprintf-posix
+++ b/modules/vasprintf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX compatible vsprintf with automatic memory allocation.
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 m4/vasprintf-posix.m4
 m4/printf.m4

diff --git a/modules/vdprintf-posix b/modules/vdprintf-posix
index bc1cb88928e05d2b4c682dfcb8cdec467a90f01f..649eacfce4b4b10958fd9feb9d6d2b1e821d0b8d 100644 (file)
--- a/modules/vdprintf-posix
+++ b/modules/vdprintf-posix
@@ -2,6 +2,12 @@ Description:
 POSIX compatible vdprintf() function: print formatted output to a file
 descriptor
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 m4/vdprintf-posix.m4
 m4/printf.m4

diff --git a/modules/vfprintf-posix b/modules/vfprintf-posix
index b622564151fc64eba5a63d4f2b1e8841fe96d18f..45af3638f5e777c47de1db92d05ba6297fd91adc 100644 (file)
--- a/modules/vfprintf-posix
+++ b/modules/vfprintf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX compatible vfprintf() function: print formatted output to a stream
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 lib/vfprintf.c
 m4/vfprintf-posix.m4

diff --git a/modules/vprintf-posix b/modules/vprintf-posix
index 2007000ae2b8827a0b9f11adacbfe13db3a638f6..319d83d6bcbe26543ad1e1c80be1a6cffb4ba76c 100644 (file)
--- a/modules/vprintf-posix
+++ b/modules/vprintf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX compatible vprintf() function: print formatted output to standard output
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 lib/vprintf.c
 m4/vprintf-posix.m4

diff --git a/modules/vsnprintf-posix b/modules/vsnprintf-posix
index dda0c3214e906971f8f26e33c1eebb11f6118b93..0f36cd990912fb267b6c3022fcd46e3c3b4e5171 100644 (file)
--- a/modules/vsnprintf-posix
+++ b/modules/vsnprintf-posix
@@ -2,6 +2,12 @@ Description:
 POSIX compatible vsnprintf() function: print formatted output to a fixed length
 string
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 m4/vsnprintf-posix.m4
 m4/printf.m4

diff --git a/modules/vsprintf-posix b/modules/vsprintf-posix
index 96730b34653806923fce9078e9d278027256e775..44d89f54073e1e9db187d6a12a010521514c10b2 100644 (file)
--- a/modules/vsprintf-posix
+++ b/modules/vsprintf-posix
@@ -1,6 +1,12 @@
 Description:
 POSIX compatible vsprintf() function: print formatted output to a string
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 lib/vsprintf.c
 m4/vsprintf-posix.m4

diff --git a/modules/xprintf-posix b/modules/xprintf-posix
index 495f7996e4b741a5dbcefb0038df2052af545b11..d25741e876be7aa9216f38a08bb4c0a874e6f6c8 100644 (file)
--- a/modules/xprintf-posix
+++ b/modules/xprintf-posix
@@ -2,6 +2,12 @@ Description:
 A wrapper around printf with POSIX compatible format string interpretation,
 that calls error upon ENOMEM or EILSEQ errors.
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 
 Depends-on:

diff --git a/modules/xvasprintf-posix b/modules/xvasprintf-posix
index b95ebb8f18e318b77198b7529d3ec8c7f79965f4..8811f9c89cef3b6a271fd852ba272cbfa6db593e 100644 (file)
--- a/modules/xvasprintf-posix
+++ b/modules/xvasprintf-posix
@@ -2,6 +2,12 @@ Description:
 vasprintf and asprintf with POSIX compatible format string interpretation and
 with out-of-memory checking.  Also see xalloc-die.
 
+Comment:
+This module should not be used as a dependency from a test module,
+otherwise when this module occurs as a tests-related module, it will
+have side effects on the compilation of the 'vasnprintf' module, if
+that module occurs among the main modules in lib/.
+
 Files:
 
 Depends-on:

diff --git a/tests/test-ceilf2.c b/tests/test-ceilf2.c
index 5c92393367c9c1ee3c26f99532160d8327be13b7..705c19a3549472384c23889d8030143c7ce523cf 100644 (file)
--- a/tests/test-ceilf2.c
+++ b/tests/test-ceilf2.c
@@ -16,6 +16,9 @@
 
 /* Written by Bruno Haible <bruno@clisp.org>, 2007.  */
 
+/* When this test fails on some platform, build it together with the gnulib
+   module 'fprintf-posix' for optimal debugging output.  */
+
 #include <config.h>
 
 #include <math.h>
@@ -119,8 +122,10 @@ check (float x)
       return 0;
     else
       {
+#if GNULIB_TEST_FPRINTF_POSIX
         fprintf (stderr, "ceilf %g(%a) = %g(%a) or %g(%a)?\n",
                  x, x, reference, reference, result, result);
+#endif
         return 1;
       }
   }

diff --git a/tests/test-floorf2.c b/tests/test-floorf2.c
index 573a648ea1879eba106945eadd1ffe442d135d3d..b26a508351d875fb38177d05ebdce6e318fff3e2 100644 (file)
--- a/tests/test-floorf2.c
+++ b/tests/test-floorf2.c
@@ -16,6 +16,9 @@
 
 /* Written by Bruno Haible <bruno@clisp.org>, 2007.  */
 
+/* When this test fails on some platform, build it together with the gnulib
+   module 'fprintf-posix' for optimal debugging output.  */
+
 #include <config.h>
 
 #include <math.h>
@@ -119,8 +122,10 @@ check (float x)
       return 0;
     else
       {
+#if GNULIB_TEST_FPRINTF_POSIX
         fprintf (stderr, "floorf %g(%a) = %g(%a) or %g(%a)?\n",
                  x, x, reference, reference, result, result);
+#endif
         return 1;
       }
   }

diff --git a/tests/test-round2.c b/tests/test-round2.c
index cad256d11c971b0b12e7fecab6b995ad48812706..8c3eda054a23d5a27534b9096c8dbbc7d4206437 100644 (file)
--- a/tests/test-round2.c
+++ b/tests/test-round2.c
@@ -17,6 +17,9 @@
 /* Written by Ben Pfaff <blp@gnu.org>, 2007.
    Heavily based on code by Bruno Haible. */
 
+/* When this test fails on some platform, build it together with the gnulib
+   module 'fprintf-posix' for optimal debugging output.  */
+
 /* Get the two reference implementations of round under the names
    round_reference1 and round_reference2.
 
@@ -62,8 +65,10 @@ equal (const char *message, DOUBLE x, DOUBLE y0, DOUBLE y1)
     return true;
   else
     {
+#if GNULIB_TEST_FPRINTF_POSIX
       fprintf (stderr, "%s: "FUNCTION"(%g(%a)) = %g(%a) or %g(%a)?\n",
                message, x, x, y0, y0, y1, y1);
+#endif
       return false;
     }
 }

diff --git a/tests/test-trunc2.c b/tests/test-trunc2.c
index 397e1ade0d1488d1e057b29cd09fd56dc36e1f60..c9f0d8fdd675a5d45df0f4ccad11755df705899a 100644 (file)
--- a/tests/test-trunc2.c
+++ b/tests/test-trunc2.c
@@ -16,6 +16,9 @@
 
 /* Written by Bruno Haible <bruno@clisp.org>, 2007.  */
 
+/* When this test fails on some platform, build it together with the gnulib
+   module 'fprintf-posix' for optimal debugging output.  */
+
 #include <config.h>
 
 #include <math.h>
@@ -123,8 +126,10 @@ check (double x)
       return 0;
     else
       {
+#if GNULIB_TEST_FPRINTF_POSIX
         fprintf (stderr, "trunc %g(%a) = %g(%a) or %g(%a)?\n",
                  x, x, reference, reference, result, result);
+#endif
         return 1;
       }
   }

diff --git a/tests/test-truncf2.c b/tests/test-truncf2.c
index 2d78808f9199374e550792191fb8135b0439262f..f19ed837d4123773c2e775969713de079a156bb6 100644 (file)
--- a/tests/test-truncf2.c
+++ b/tests/test-truncf2.c
@@ -16,6 +16,9 @@
 
 /* Written by Bruno Haible <bruno@clisp.org>, 2007.  */
 
+/* When this test fails on some platform, build it together with the gnulib
+   module 'fprintf-posix' for optimal debugging output.  */
+
 #include <config.h>
 
 #include <math.h>
@@ -123,8 +126,10 @@ check (float x)
       return 0;
     else
       {
+#if GNULIB_TEST_FPRINTF_POSIX
         fprintf (stderr, "truncf %g(%a) = %g(%a) or %g(%a)?\n",
                  x, x, reference, reference, result, result);
+#endif
         return 1;
       }
   }