bridge: Avoid duplicate logging when netdev_get_etheraddr() fails.
authorBen Pfaff <blp@nicira.com>
Thu, 16 Jun 2011 21:05:17 +0000 (14:05 -0700)
committerBen Pfaff <blp@nicira.com>
Fri, 17 Jun 2011 20:38:31 +0000 (13:38 -0700)
get_etheraddr() in netdev-linux.c logs when the Ethernet address cannot be
obtained so there is no need to log again in the caller.

Bug #5844.

vswitchd/bridge.c

index 9868ef5b627e92cfd0f2b786f8eaa0395e37cb88..3a9cfa9de8d08ada8a478265cc9c43f6e3c33340 100644 (file)
@@ -1023,9 +1023,6 @@ bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
             /* Grab MAC. */
             error = netdev_get_etheraddr(iface->netdev, iface_ea);
             if (error) {
-                static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
-                VLOG_ERR_RL(&rl, "failed to obtain Ethernet address of %s: %s",
-                            iface->name, strerror(error));
                 continue;
             }
         }