* gc-pbkdf2-sha1.c (gc_pbkdf2_sha1): Optimize CEIL computation.

Move memory allocation outside of loop.

diff --git a/lib/ChangeLog b/lib/ChangeLog
index da26e24ff125e6d32dfaf158d5a63effad088df7..42e14eb9103adb72f11b2ff251f6436d5f2dc772 100644 (file)
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,8 @@
+2005-10-13  Simon Josefsson  <jas@extundo.com>
+
+       * gc-pbkdf2-sha1.c (gc_pbkdf2_sha1): Optimize CEIL computation.
+       Move memory allocation outside of loop.
+
 2005-10-12  Simon Josefsson  <jas@extundo.com>
 
        * gc-pbkdf2-sha1.c: New file.

diff --git a/lib/gc-pbkdf2-sha1.c b/lib/gc-pbkdf2-sha1.c
index afdfcdb06585886fd2a7c93bc3f89454b09bcbad..0c105aab9334295850a0d32fd5e081aa86112e01 100644 (file)
--- a/lib/gc-pbkdf2-sha1.c
+++ b/lib/gc-pbkdf2-sha1.c
@@ -68,6 +68,8 @@ gc_pbkdf2_sha1 (const char *P, size_t Plen,
   unsigned int i;
   unsigned int k;
   int rc;
+  char *tmp;
+  size_t tmplen = Slen + 4;
 
   if (c == 0)
     return GC_PKCS5_INVALID_ITERATION_COUNT;
@@ -98,9 +100,7 @@ gc_pbkdf2_sha1 (const char *P, size_t Plen,
    *        integer greater than, or equal to, x.
    */
 
-  l = dkLen / hLen;
-  if (dkLen % hLen)
-    l++;
+  l = ((dkLen - 1) / hLen) + 1;
   r = dkLen - (l - 1) * hLen;
 
   /*
@@ -145,6 +145,12 @@ gc_pbkdf2_sha1 (const char *P, size_t Plen,
    *
    */
 
+  tmp = malloc (tmplen);
+  if (tmp == NULL)
+    return GC_MALLOC_ERROR;
+
+  memcpy (tmp, S, Slen);
+
   for (i = 1; i <= l; i++)
     {
       memset (T, 0, hLen);
@@ -153,28 +159,21 @@ gc_pbkdf2_sha1 (const char *P, size_t Plen,
        {
          if (u == 1)
            {
-             char *tmp;
-             size_t tmplen = Slen + 4;
-
-             tmp = malloc (tmplen);
-             if (tmp == NULL)
-               return GC_MALLOC_ERROR;
-
-             memcpy (tmp, S, Slen);
              tmp[Slen + 0] = (i & 0xff000000) >> 24;
              tmp[Slen + 1] = (i & 0x00ff0000) >> 16;
              tmp[Slen + 2] = (i & 0x0000ff00) >> 8;
              tmp[Slen + 3] = (i & 0x000000ff) >> 0;
 
              rc = gc_hmac_sha1 (P, Plen, tmp, tmplen, U);
-
-             free (tmp);
            }
          else
            rc = gc_hmac_sha1 (P, Plen, U, hLen, U);
 
          if (rc != GC_OK)
-           return rc;
+           {
+             free (tmp);
+             return rc;
+           }
 
          for (k = 0; k < hLen; k++)
            T[k] ^= U[k];
@@ -183,5 +182,7 @@ gc_pbkdf2_sha1 (const char *P, size_t Plen,
       memcpy (DK + (i - 1) * hLen, T, i == l ? r : hLen);
     }
 
+  free (tmp);
+
   return GC_OK;
 }