Fix memmem test for mingw.

* modules/memmem-tests (configure.ac): Check for alarm.
* tests/test-memmem.c (main): Avoid alarm on platforms that lack
it.
* doc/functions/memmem.texi: New file.
* doc/gnulib.texi (Function Substitutes): Add memmem.
Reported by Bruno Haible.

Signed-off-by: Eric Blake <ebb9@byu.net>

diff --git a/ChangeLog b/ChangeLog
index bdf61e2687c3857d26fd87c5f7e6b38b1f3a75ab..b4be78ecac2c6f4c48aa4f42763312bdfb8e5c1c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2008-01-05  Eric Blake  <ebb9@byu.net>
+
+       Fix memmem test for mingw.
+       * modules/memmem-tests (configure.ac): Check for alarm.
+       * tests/test-memmem.c (main): Avoid alarm on platforms that lack
+       it.
+       * doc/functions/memmem.texi: New file.
+       * doc/gnulib.texi (Function Substitutes): Add memmem.
+       Reported by Bruno Haible.
+
 2008-01-04  Bruno Haible  <bruno@clisp.org>
 
        * m4/strcase.m4 (gl_FUNC_STRCASECMP, gl_FUNC_STRNCASECMP):

diff --git a/doc/functions/memmem.texi b/doc/functions/memmem.texi
new file mode 100644 (file)
index 0000000..50d73fd
--- /dev/null
+++ b/doc/functions/memmem.texi
@@ -0,0 +1,28 @@
+@node memmem
+@section @code{memmem}
+@findex memmem
+
+Unspecified by POSIX, but comparable to @code{strstr}.
+
+Gnulib module: memmem
+
+Portability problems fixed by Gnulib:
+@itemize
+@item
+This function fails to return the start of the haystack for an empty
+needle on some platforms:
+Cygwin 1.5.x
+
+@item
+This function has quadratic instead of linear complexity on some
+platforms:
+glibc <= 2.6.1
+
+@item
+This function is missing on some platforms:
+Mingw, OpenBSD 4.0
+@end itemize
+
+Portability problems not fixed by Gnulib:
+@itemize
+@end itemize

diff --git a/doc/gnulib.texi b/doc/gnulib.texi
index f46096b8c6e883c878f33cf372cb61f13f556fcc..deaf5282310e256b991f3742520d2d7e452bafd3 100644 (file)
--- a/doc/gnulib.texi
+++ b/doc/gnulib.texi
@@ -17,7 +17,8 @@ This manual is for GNU Gnulib (updated @value{UPDATED}),
 which is a library of common routines intended to be shared at the
 source level.
 
-Copyright @copyright{} 2004, 2005, 2006, 2007 Free Software Foundation, Inc.
+Copyright @copyright{} 2004, 2005, 2006, 2007, 2008 Free Software
+Foundation, Inc.
 
 Permission is granted to copy, distribute and/or modify this document
 under the terms of the GNU Free Documentation License, Version 1.1 or
@@ -1174,6 +1175,7 @@ If you need this particular function, you may write to
 * memchr::
 * memcmp::
 * memcpy::
+* memmem::
 * memmove::
 * memset::
 * mkdir::

diff --git a/modules/memmem-tests b/modules/memmem-tests
index 3d79e477eb99690178d3f64d4c6e9408b0a20b3c..c9365e906b0621d68b1084a8b6bbbb45f6b33d90 100644 (file)
--- a/modules/memmem-tests
+++ b/modules/memmem-tests
@@ -4,6 +4,7 @@ tests/test-memmem.c
 Depends-on:
 
 configure.ac:
+AC_CHECK_DECLS_ONCE([alarm])
 
 Makefile.am:
 TESTS += test-memmem

diff --git a/tests/test-memmem.c b/tests/test-memmem.c
index df3baef897fb5c1f31b83c114e77a03bbc5b2324..976f293137e2f7edd883425845a83a18d86672fa 100644 (file)
--- a/tests/test-memmem.c
+++ b/tests/test-memmem.c
@@ -37,9 +37,14 @@
 int
 main (int argc, char *argv[])
 {
+#if HAVE_DECL_ALARM
   /* Declare failure if test takes too long, by using default abort
-     caused by SIGALRM.  */
+     caused by SIGALRM.  All known platforms that lack alarm also lack
+     memmem, and the replacement memmem is known to not take too
+     long.  */
   alarm (10);
+#endif
+
   {
     const char input[] = "foo";
     const char *result = memmem (input, strlen (input), "", 0);