pt_chown: Don't depend on GPLed modules.

diff --git a/ChangeLog b/ChangeLog
index 8166c5d793668edb565e4cce0328a6a6d9ec56d1..0b1dc208c18436c8149309e179371debe2cb2293 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2010-03-23  Bruno Haible  <bruno@clisp.org>
+
+       pt_chown: Don't depend on GPLed modules.
+       * lib/pt_chown.c: Don't include idpriv.h.
+       (main): Don't drop privileges.
+       * modules/pt_chown (Depends-on): Remove idpriv-drop.
+       Reported by Simon Josefsson.
+
 2010-03-24  Simon Josefsson  <simon@josefsson.org>
 
        * top/maint.mk (sc_texinfo_acronym): Add rule, based on

diff --git a/lib/pt_chown.c b/lib/pt_chown.c
index d79ad3a87ca2405c8682df1de9fe6c31cb2a49ba..8ecaa902cb95b8a0be49c01d500a5743210653e0 100644 (file)
--- a/lib/pt_chown.c
+++ b/lib/pt_chown.c
@@ -25,7 +25,6 @@
 #include <sys/stat.h>
 #include <unistd.h>
 
-#include "idpriv.h"
 #include "pty-private.h"
 
 /* For security reasons, we try to minimize the dependencies on libraries
@@ -83,9 +82,8 @@ main (int argc, char *argv[])
       return do_pt_chown ();
     }
 
-  /* We aren't going to be using privileges, so drop them right now. */
-  if (idpriv_drop () < 0)
-    return EXIT_FAILURE;
+  /* It would be possible to drop setuid/setgid privileges here.  But it is not
+     really needed, since the code below only calls strcmp and [f]printf.  */
 
   {
     int do_help = 0;

diff --git a/modules/pt_chown b/modules/pt_chown
index 8cae3d148f0c232b7e45a915e777ea1d9ed990b9..a52fef0d08570a490be42865730f75f5a9369370 100644 (file)
--- a/modules/pt_chown
+++ b/modules/pt_chown
@@ -6,7 +6,6 @@ lib/pt_chown.c
 lib/pty-private.h
 
 Depends-on:
-idpriv-drop
 ptsname
 
 configure.ac: