Fix race condition in parallel execution of "make install".
authorBen Pfaff <blp@nicira.com>
Mon, 23 Jul 2012 16:54:16 +0000 (09:54 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 23 Jul 2012 19:36:11 +0000 (12:36 -0700)
ovs-vsctl is listed, incorrectly, in both bin_PROGRAMS and bin_SCRIPTS.
This meant that "make install" with the -j option could try to install
ovs-vsctl two times in parallel, a race that occasionally caused a build
failure, e.g.:
http://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=s390&ver=1.4.2%2Bgit20120612-5&stamp=1342851603

Debian bug #682384.
CC: 682384@bugs.debian.org
Reported-by: Bastian Blank <waldi@debian.org>
Signed-off-by: Ben Pfaff <blp@nicira.com>
utilities/automake.mk

index 04a7fdccac7c64c6819fc218f5d2e6dce6b075c5..7bb2c6d61cfee1e3070b822f5b951b86267be713 100644 (file)
@@ -4,7 +4,7 @@ bin_PROGRAMS += \
        utilities/ovs-dpctl \
        utilities/ovs-ofctl \
        utilities/ovs-vsctl
-bin_SCRIPTS += utilities/ovs-pki utilities/ovs-vsctl utilities/ovs-parse-leaks
+bin_SCRIPTS += utilities/ovs-pki utilities/ovs-parse-leaks
 if HAVE_PYTHON
 bin_SCRIPTS += \
        utilities/ovs-l3ping \