placement-parser: Properly handle LONG_MAX != INT_MAX.
authorBen Pfaff <blp@cs.stanford.edu>
Mon, 3 Aug 2020 00:44:40 +0000 (00:44 +0000)
committerBen Pfaff <blp@cs.stanford.edu>
Mon, 3 Aug 2020 00:45:34 +0000 (00:45 +0000)
Also, delete spurious null bytes from the related test.  The null
bytes spurred a test failure on mingw although I am not sure why.

src/language/data-io/placement-parser.c
tests/language/lexer/lexer.at

index 443b9b591643e68faf3e307471d29b81cdb3720d..671933382a534054816dc89c66e6892ed31a2475 100644 (file)
@@ -401,16 +401,17 @@ parse_record_placement (struct lexer *lexer, int *record, int *column)
     {
       if (lex_is_integer (lexer))
         {
-          if ((int) lex_integer (lexer) <= *record)
+          long n = lex_integer (lexer);
+          if (n <= *record || n > INT_MAX)
             {
               msg (SE, _("The record number specified, %ld, is at or "
                          "before the previous record, %d.  Data "
                          "fields must be listed in order of "
                          "increasing record number."),
-                   lex_integer (lexer), *record);
+                   n, *record);
               return false;
             }
-          *record = lex_integer (lexer);
+          *record = n;
           lex_get (lexer);
         }
       else
index 879e08785f1d0eb395d333b078cea27fb278b276..25ced0d9ab199a4fd59a7935a419117aed9f4b3b 100644 (file)
Binary files a/tests/language/lexer/lexer.at and b/tests/language/lexer/lexer.at differ