Add comment about low quality of this function.

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 581842c841bcead3759e2f4be8afde5fab8a8347..e9e298133aec7b572118200ddeb2541a53bd187b 100644 (file)
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,7 @@
+2003-01-11  Bruno Haible  <bruno@clisp.org>
+
+       * hash-pjw.c: Add comment about low quality of this function.
+
 2003-01-12  Paul Eggert  <eggert@twinsun.com>
 
        Finish renaming getstr -> getdelim2 and readline -> readlinebuffer,

diff --git a/lib/hash-pjw.c b/lib/hash-pjw.c
index 141b08b51f727c072e1fdb141ed355d02d959533..0a14b3e7af9b1f28008b253b3a44827fbf38fa77 100644 (file)
--- a/lib/hash-pjw.c
+++ b/lib/hash-pjw.c
@@ -1,5 +1,5 @@
 /* hash-pjw.c -- compute a hash value from a NUL-terminated string.
-   Copyright 2001 Free Software Foundation, Inc.
+   Copyright 2001, 2003 Free Software Foundation, Inc.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -22,7 +22,10 @@
 #include "hash-pjw.h"
 
 /* A hash function for NUL-terminated char* strings using
-   the method described in Aho, Sethi, & Ullman, p 436. */
+   the method described in Aho, Sethi, & Ullman, p 436.
+   Note that this hash function produces a lot of collisions when used
+   with short strings with very varied bit patterns.
+   See http://www.haible.de/bruno/hashfunc.html.  */
 
 unsigned int
 hash_pjw (const void *x, unsigned int tablesize)