PsppireDataWindow: Fix use after free error
authorJohn Darrington <john@darrington.wattle.id.au>
Sat, 27 Jun 2020 05:27:25 +0000 (07:27 +0200)
committerJohn Darrington <john@darrington.wattle.id.au>
Sat, 27 Jun 2020 05:27:25 +0000 (07:27 +0200)
src/ui/gui/psppire-data-window.c

index 73fb1e1bb1a3c1daa2a1cf696beff502f3b7a0b2..6a0d4719c9af2fe644eb7e76f0341979982499b7 100644 (file)
@@ -918,13 +918,12 @@ on_recent_files_select (GtkMenuShell *menushell,   gpointer user_data)
 
   se = psppire_syntax_window_new (encoding);
 
-  free (encoding);
-
   if (psppire_window_load (PSPPIRE_WINDOW (se), file, encoding, NULL))
     gtk_widget_show (se);
   else
     gtk_widget_destroy (se);
 
+  g_free (encoding);
   g_free (file);
 }