dpctl: Exit unsuccessfully if a write to stdout or stderr failed.

A program should exit with an error if its output failed, so check for
this before termination.

Found by Chris Eagle via Fortify.

diff --git a/utilities/dpctl.c b/utilities/dpctl.c
index c6de5a1e4a225e3c404c67a2c27e7bc9d26a1b35..0113d9674d4144a4292d47ef91c701b363be1222 100644 (file)
--- a/utilities/dpctl.c
+++ b/utilities/dpctl.c
@@ -123,6 +123,12 @@ int main(int argc, char *argv[])
                           p->name, p->max_args);
             else {
                 p->handler(&s, argc, argv);
+                if (ferror(stdout)) {
+                    ofp_fatal(0, "write to stdout failed");
+                }
+                if (ferror(stderr)) {
+                    ofp_fatal(0, "write to stderr failed");
+                }
                 exit(0);
             }
         }