Fix typos in comments.
authorBen Pfaff <blp@nicira.com>
Thu, 4 Nov 2010 17:32:13 +0000 (10:32 -0700)
committerBen Pfaff <blp@nicira.com>
Fri, 5 Nov 2010 16:25:37 +0000 (09:25 -0700)
include/openflow/nicira-ext.h
lib/ofp-util.h

index 55b3548d75b46c6c106522fc1aaf05c1fabbe047..fcdbba4f40a2f77cb6d090041f790d69f1cb144d 100644 (file)
@@ -42,7 +42,7 @@
  * vendor-specific details, followed by at least 64 bytes of the failed
  * request.
  *
- * It would be better to have type-specific vendor extension, e.g. so that
+ * It would be better to have type-specific vendor extension, e.g. so that
  * OFPET_BAD_ACTION could be used with vendor-specific code values.  But
  * OFPET_BAD_ACTION and most other standardized types already specify that
  * their 'data' values are (the start of) the OpenFlow message being replied
index d72a50bd2549abf8973cb3fc823753c6736041a6..1c683eca97d61cf7d27c331a9118b16578b8845d 100644 (file)
@@ -85,7 +85,12 @@ char *ofp_match_to_literal_string(const struct ofp_match *match);
 \f
 /* OpenFlow vendors.
  *
- * These functions map vendor */
+ * These functions map OpenFlow 32-bit vendor IDs (as used in struct
+ * ofp_vendor_header) into 4-bit values to embed in an "int".  The 4-bit values
+ * are only used internally in Open vSwitch and never appear on the wire, so
+ * particular codes used are not important.
+ */
+
 /* Vendor error numbers currently used in Open vSwitch. */
 #define OFPUTIL_VENDORS                                     \
     /*             vendor name              vendor value */ \
@@ -106,19 +111,19 @@ enum ofputil_vendor_codes {
  * error codes into a single 31-bit space using the following encoding.
  * (Bit 31 is unused and assumed 0 to avoid negative "int" values.)
  *
- *   31                                                   0
+ *   30                                                   0
  *  +------------------------------------------------------+
  *  |                           0                          |  success
  *  +------------------------------------------------------+
  *
  *   30 29                                                0
  *  +--+---------------------------------------------------+
- *  ||                    errno value                    |  errno value
+ *  | 0|                    errno value                    |  errno value
  *  +--+---------------------------------------------------+
  *
  *   30 29   26 25            16 15                       0
  *  +--+-------+----------------+--------------------------+
- *  ||   0   |      type      |           code           |  standard OpenFlow
+ *  | 1|   0   |      type      |           code           |  standard OpenFlow
  *  +--+-------+----------------+--------------------------+  error
  *
  *   30 29   26 25            16 15                       0