regcomp.c: avoid the sole warning from gcc's -Wtype-limits

* lib/regcomp.c (TYPE_SIGNED): Define.
(parse_dup_op): Use it to avoid the sole warning from -Wtype-limits.

diff --git a/ChangeLog b/ChangeLog
index fb38064dc3221feb54dfc58053d33476ac79a628..093bdcfa8be91aa31f427fa2aa10a2509263639f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2010-02-03  Jim Meyering  <meyering@redhat.com>
 
+       regcomp.c: avoid the sole warning from gcc's -Wtype-limits
+       * lib/regcomp.c (TYPE_SIGNED): Define.
+       (parse_dup_op): Use it to avoid the sole warning from -Wtype-limits.
+
        regcomp.c: avoid a new -Wshadow warning
        * lib/regcomp.c (create_initial_state): Do not shadow local "err".
 

diff --git a/lib/regcomp.c b/lib/regcomp.c
index 32997ccdd536220e8bc4146320cb4f23912e4caa..d5968bd501905614f9a9610822010d8b233cf51a 100644 (file)
--- a/lib/regcomp.c
+++ b/lib/regcomp.c
@@ -2577,10 +2577,14 @@ parse_dup_op (bin_tree_t *elem, re_string_t *regexp, re_dfa_t *dfa,
   if (BE (tree == NULL, 0))
     goto parse_dup_op_espace;
 
+/* From gnulib's "intprops.h":
+   True if the arithmetic type T is signed.  */
+#define TYPE_SIGNED(t) (! ((t) 0 < (t) -1))
+
   /* This loop is actually executed only when end != REG_MISSING,
      to rewrite <re>{0,n} as (<re>(<re>...<re>?)?)?...  We have
      already created the start+1-th copy.  */
-  if ((Idx) -1 < 0 || end != REG_MISSING)
+  if (TYPE_SIGNED (Idx) || end != REG_MISSING)
     for (i = start + 2; i <= end; ++i)
       {
        elem = duplicate_tree (elem, dfa);