tunnel: Drop spinlock around cache free.

We hold a spinlock when freeing the cache, since you're generally
supposed to do that when writing to RCU protected data.  However,
there's really no point in doing that here because the port has
already been removed from both the transmit and receive side
data structures and we've waited for an RCU grace period.  In
addition, we're about to free the port itself, which contains the
spinlock and will be in trouble if anyone else is trying to
access it.  For clarity, drop the spinlock.

Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>

diff --git a/datapath/tunnel.c b/datapath/tunnel.c
index ce1d8eb524663afd93f741fc5a550783feca99a0..ee9e45d31a750586cb9ea2621c8529a6a1cbe271 100644 (file)
--- a/datapath/tunnel.c
+++ b/datapath/tunnel.c
@@ -1458,10 +1458,7 @@ static void free_port_rcu(struct rcu_head *rcu)
 {
        struct tnl_vport *tnl_vport = container_of(rcu, struct tnl_vport, rcu);
 
-       spin_lock_bh(&tnl_vport->cache_lock);
        free_cache(tnl_vport->cache);
-       spin_unlock_bh(&tnl_vport->cache_lock);
-
        kfree(tnl_vport->mutable);
        vport_free(tnl_vport_to_vport(tnl_vport));
 }