ofproto: Fix over accounting of byte counters.
authorEthan Jackson <ethan@nicira.com>
Tue, 16 Aug 2011 21:16:58 +0000 (14:16 -0700)
committerEthan Jackson <ethan@nicira.com>
Tue, 16 Aug 2011 21:33:17 +0000 (14:33 -0700)
The update_stats() function in ofproto was attributing more bytes
to facets than they had actually accrued.  This could potentially
throw off bond load balancing.

Found by inspection.

ofproto/ofproto-dpif.c

index fdd20571800af29c5868f913148101fd476c65da..3aa0e78600f823ffd155d7aaaa7a81423be895e0 100644 (file)
@@ -1849,7 +1849,7 @@ update_stats(struct ofproto_dpif *p)
             facet->dp_byte_count = stats->n_bytes;
 
             facet_update_time(p, facet, stats->used);
-            facet_account(p, facet, stats->n_bytes);
+            facet_account(p, facet, 0);
             facet_push_stats(facet);
         } else {
             /* There's a flow in the datapath that we know nothing about.