ftoastr: depend on snprintf, improve comments

* lib/ftoastr.c: Also mention Loitsch's draft.
* lib/ftoastr.h: Require WIDTH to be nonnegative.  This isn't
needed in the current implementation, but it might simplify
speeding up the code later.
* modules/ftoastr: Depend on snprintf; this improves portability.
Suggested by Bruno Haible in the same email.

diff --git a/ChangeLog b/ChangeLog
index a1043bd7032a2bb9e379eb350a6defecfed2de70..217fbba012acbd48a28e85786236ac65283552fb 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2010-11-18  Paul Eggert  <eggert@cs.ucla.edu>
 
+       ftoastr: depend on snprintf, improve comments
+       * lib/ftoastr.c: Also mention Loitsch's draft.
+       * lib/ftoastr.h: Require WIDTH to be nonnegative.  This isn't
+       needed in the current implementation, but it might simplify
+       speeding up the code later.
+       * modules/ftoastr: Depend on snprintf; this improves portability.
+       Suggested by Bruno Haible in the same email.
+
        ftoastr: port to hosts lacking strtof and strtold
        Problem reported by Bruno Haible in
        <http://lists.gnu.org/archive/html/bug-gnulib/2010-11/msg00242.html>.

diff --git a/lib/ftoastr.c b/lib/ftoastr.c
index ddc525168abb6867900e1b730d33feb60b799e13..f74740088e971b19805c3e89a1c3d771b763b16a 100644 (file)
--- a/lib/ftoastr.c
+++ b/lib/ftoastr.c
@@ -64,7 +64,8 @@ FTOASTR (char *buf, size_t bufsize, int flags, int width, FLOAT x)
 
      Florian Loitsch, Printing floating-point numbers quickly and accurately
      with integers.  ACM SIGPLAN notices 46, 6 (June 2010), 233-243
-     <http://dx.doi.org/10.1145/1809028.1806623>.  */
+     <http://dx.doi.org/10.1145/1809028.1806623>; also see the
+     2010-03-21 draft <http://florian.loitsch.com/tmp/article.pdf>.  */
 
   char format[sizeof "%-+ 0*.*Lg"];
   FLOAT abs_x = x < 0 ? -x : x;

diff --git a/lib/ftoastr.h b/lib/ftoastr.h
index 4c4f890cd2619736c573b23bc586325e30e29089..fd7a802dbecb4767dcd7c9d437af82a72aeec51c 100644 (file)
--- a/lib/ftoastr.h
+++ b/lib/ftoastr.h
@@ -26,8 +26,8 @@
 /* Store into BUF (of size BUFSIZE) an accurate minimal-precision
    string representation of a floating point number.  FLAGS affect the
    formatting of the number.  Pad the output string with spaces as
-   necessary to width WIDTH bytes, in the style of printf.  X is the
-   floating-point number to be converted.
+   necessary to width WIDTH bytes, in the style of printf.  WIDTH must
+   be nonnegative.  X is the floating-point number to be converted.
 
    Return the number of bytes stored into BUF, not counting the
    terminating null.  However, do not overrun BUF: if BUF is too

diff --git a/modules/ftoastr b/modules/ftoastr
index 64d0a77903ca8af95ed11b509f6ebd79c83f422a..862fb1aa21d9243648168b9459ad9f11821863f0 100644 (file)
--- a/modules/ftoastr
+++ b/modules/ftoastr
@@ -10,6 +10,7 @@ m4/c-strtod.m4
 
 Depends-on:
 intprops
+snprintf
 
 configure.ac:
 AC_REQUIRE([gl_C99_STRTOLD])