python: Avoid using 'tuple' as a variable name.
authorBen Pfaff <blp@nicira.com>
Tue, 23 Aug 2011 17:50:47 +0000 (10:50 -0700)
committerBen Pfaff <blp@nicira.com>
Wed, 24 Aug 2011 18:57:42 +0000 (11:57 -0700)
'tuple' is a Python built-in function, so it's best to avoid using it as a
variable name.

Suggested-by: Reid Price <reid@nicira.com>
python/ovs/stream.py

index c1ce422fa43ca71a518a6272b93bdc327780ff95..16e383a0c7dc16e38103cdff0542b2dbf4c74a44 100644 (file)
@@ -88,15 +88,14 @@ class Stream(object):
             return 0, Stream(sock, name, bind_path, status)
 
     @staticmethod
-    def open_block(tuple):
+    def open_block((error, stream)):
         """Blocks until a Stream completes its connection attempt, either
-        succeeding or failing.  'tuple' should be the tuple returned by
+        succeeding or failing.  (error, stream) should be the tuple returned by
         Stream.open().  Returns a tuple of the same form.
 
         Typical usage:
-        error, stream = Stream.open_block(Stream.open("tcp:1.2.3.4:5"))"""
+        error, stream = Stream.open_block(Stream.open("unix:/tmp/socket"))"""
 
-        error, stream = tuple
         if not error:
             while True:
                 error = stream.connect()