ofproto-dpif: Allow OpenFlow rules that have facets to expire.
authorBen Pfaff <blp@nicira.com>
Thu, 2 Feb 2012 01:08:28 +0000 (17:08 -0800)
committerBen Pfaff <blp@nicira.com>
Mon, 27 Feb 2012 17:51:42 +0000 (09:51 -0800)
At one time (before facets were called facets), the existence of a facet
implied that its parent rule was not idle.  This is no longer true, so
remove the check.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ofproto/ofproto-dpif.c

index b5e316bf8effb86ef9c58169f2c1677ac2ec4cb3..c025dff40d035ddc6612366dd2d540c813a56268 100644 (file)
@@ -3110,7 +3110,7 @@ rule_expire(struct rule_dpif *rule)
     if (rule->up.hard_timeout
         && now > rule->up.modified + rule->up.hard_timeout * 1000) {
         reason = OFPRR_HARD_TIMEOUT;
-    } else if (rule->up.idle_timeout && list_is_empty(&rule->facets)
+    } else if (rule->up.idle_timeout
                && now > rule->up.used + rule->up.idle_timeout * 1000) {
         reason = OFPRR_IDLE_TIMEOUT;
     } else {