* snprintf.c (snprintf): memcpy LEN bytes, not SIZE - 1, when

LEN is smaller than SIZE.  Suggested by Bruno Haible.
Also, help the compiler to keep LEN in a register.

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 5cf12553e84eb2464eecda7424282f4ac7bf9c0b..e1e4a5103770569bcc080be0be2e00a63da8b677 100644 (file)
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,9 @@
+2006-08-11  Paul Eggert  <eggert@cs.ucla.edu>
+
+       * snprintf.c (snprintf): memcpy LEN bytes, not SIZE - 1, when
+       LEN is smaller than SIZE.  Suggested by Bruno Haible.
+       Also, help the compiler to keep LEN in a register.
+
 2006-08-10  Paul Eggert  <eggert@cs.ucla.edu>
 
        * .cppi-disable: Add snprintf.h, socket_.h.

diff --git a/lib/snprintf.c b/lib/snprintf.c
index c281f7c5830d09318773909a9e850bc074d3ced4..ef00f55b414ed5d04a00f9b7a60de01e7c92766b 100644 (file)
--- a/lib/snprintf.c
+++ b/lib/snprintf.c
@@ -45,11 +45,12 @@ snprintf (char *str, size_t size, const char *format, ...)
 {
   char *output;
   size_t len;
+  size_t lenbuf = size;
   va_list args;
 
   va_start (args, format);
-  len = size;
   output = vasnprintf (str, &len, format, args);
+  len = lenbuf;
   va_end (args);
 
   if (!output)
@@ -59,8 +60,9 @@ snprintf (char *str, size_t size, const char *format, ...)
     {
       if (size)
        {
-         memcpy (str, output, size - 1);
-         str[size - 1] = '\0';
+         size_t pruned_len = (len < size ? len : size - 1);
+         memcpy (str, output, pruned_len);
+         str[pruned_len] = '\0';
        }
 
       free (output);