maint.mk: prohibit unwarranted use of <strings.h>

* top/maint.mk (sc_prohibit_strings_without_use): Reject inclusion of
strings.h in a file that does not also use strcasecmp, strncasecmp,
ffs or ffsll.

diff --git a/ChangeLog b/ChangeLog
index 797a38141585381fe20d1e4e2927b5a9f60b32c2..4378ddbc96f77a7a590c7cae8daba63e8f65be49 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -6,6 +6,11 @@
 
 2010-05-03  Jim Meyering  <meyering@redhat.com>
 
+       maint.mk: prohibit unwarranted use of <strings.h>
+       * top/maint.mk (sc_prohibit_strings_without_use): Reject inclusion of
+       strings.h in a file that does not also use strcasecmp, strncasecmp,
+       ffs or ffsll.
+
        maint.mk: remove obsolete comments
        * top/maint.mk: Remove stale, commented-out rules.
 

diff --git a/top/maint.mk b/top/maint.mk
index 66dc9b6cb7814bfa9c90398f94a67fbce64aa8f7..9bca202b4092600b80fe80e0fe59a5dc469b5390 100644 (file)
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -544,6 +544,13 @@ sc_prohibit_signal_without_use:
        re='\<($(_sig_function_re)) *\(|\<($(_sig_syms_re))\>'          \
          $(_sc_header_without_use)
 
+# Prohibit the inclusion of strings.h without a sensible use.
+# Using the likes of bcmp, bcopy, bzero, index or rindex is not sensible.
+sc_prohibit_strings_without_use:
+       @h='<strings.h>'                                                \
+       re='\<(strn?casecmp|ffs(ll)?)\>'                                \
+         $(_sc_header_without_use)
+
 # Get the list of symbol names with this:
 # perl -lne '/^# *define (\w+)\(/ and print $1' lib/intprops.h|grep -v '^s'|fmt
 _intprops_names =                                                      \