Separate the module 'waitpid' from the module 'sys_wait'.

* lib/sys_wait.in.h (waitpid): Declare only if the 'waitpid' module is
present.
* m4/sys_wait_h.m4 (gl_SYS_WAIT_MODULE_INDICATOR): Invoke
gl_MODULE_INDICATOR_FOR_TESTS.
(gl_SYS_WAIT_H_DEFAULTS): Initialize GNULIB_WAITPID.
* modules/sys_wait (Depends-on): Remove waitpid.
(Makefile.am): Substitute GNULIB_WAITPID.
* modules/waitpid (configure.ac): Invoke gl_SYS_WAIT_MODULE_INDICATOR.
* tests/test-sys_wait-c++.cc (GNULIB_NAMESPACE::waitpid): Check the
signature only if the 'waitpid' module is present.
* doc/posix-functions/waitpid.texi: Mention the 'waitpid' module.
* NEWS: Mention the change.
* modules/grantpt (Depends-on): Add waitpid.
* modules/wait-process (Depends-on): Likewise.

diff --git a/ChangeLog b/ChangeLog
index 613fe003aab6eefa92b05bc795cbfbe9078fc439..7fdc71315a4bfa9e4cfcbc0721dcf2b7a4228acb 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,21 @@
+2010-09-29  Bruno Haible  <bruno@clisp.org>
+
+       Separate the module 'waitpid' from the module 'sys_wait'.
+       * lib/sys_wait.in.h (waitpid): Declare only if the 'waitpid' module is
+       present.
+       * m4/sys_wait_h.m4 (gl_SYS_WAIT_MODULE_INDICATOR): Invoke
+       gl_MODULE_INDICATOR_FOR_TESTS.
+       (gl_SYS_WAIT_H_DEFAULTS): Initialize GNULIB_WAITPID.
+       * modules/sys_wait (Depends-on): Remove waitpid.
+       (Makefile.am): Substitute GNULIB_WAITPID.
+       * modules/waitpid (configure.ac): Invoke gl_SYS_WAIT_MODULE_INDICATOR.
+       * tests/test-sys_wait-c++.cc (GNULIB_NAMESPACE::waitpid): Check the
+       signature only if the 'waitpid' module is present.
+       * doc/posix-functions/waitpid.texi: Mention the 'waitpid' module.
+       * NEWS: Mention the change.
+       * modules/grantpt (Depends-on): Add waitpid.
+       * modules/wait-process (Depends-on): Likewise.
+
 2010-09-29  Bruno Haible  <bruno@clisp.org>
 
        More tests for module 'sys_wait'.

diff --git a/NEWS b/NEWS
index 377898dcb843b32a791430960bf3349c1fb30fb8..2f03ac1398330068ac915ef2218e0b43eeadd57d 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,10 @@ User visible incompatible changes
 
 Date        Modules         Changes
 
+2010-09-29  sys_wait        This module no longer provides the waitpid()
+                            function. If you need this function, you now need
+                            to request the 'waitpid' module.
+
 2010-09-17  utimens         The function gl_futimens is removed, and its
                             signature has been migrated to fdutimens.  Callers
                             of gl_futimens should change function name, and

diff --git a/doc/posix-functions/waitpid.texi b/doc/posix-functions/waitpid.texi
index 71a4676fc54feb34dfae3381d4b9125077083442..9c68150d828a554de6a84a1bd6198683e5aeff31 100644 (file)
--- a/doc/posix-functions/waitpid.texi
+++ b/doc/posix-functions/waitpid.texi
@@ -4,15 +4,15 @@
 
 POSIX specification:@* @url{http://www.opengroup.org/onlinepubs/9699919799/functions/waitpid.html}
 
-Gnulib module: ---
+Gnulib module: waitpid
 
 Portability problems fixed by Gnulib:
 @itemize
+@item
+This function is missing on some platforms:
+mingw.
 @end itemize
 
 Portability problems not fixed by Gnulib:
 @itemize
-@item
-This function is missing on some platforms:
-mingw.
 @end itemize

diff --git a/lib/sys_wait.in.h b/lib/sys_wait.in.h
index 6f0ef3687d526e609afcf86518af70035918c879..727657cf2408fb3da6ca0940d03cde1dee497d41 100644 (file)
--- a/lib/sys_wait.in.h
+++ b/lib/sys_wait.in.h
@@ -113,7 +113,7 @@ extern "C" {
 
 /* Declarations of functions.  */
 
-#if 1 /* @GNULIB_WAITPID@ */
+#if @GNULIB_WAITPID@
 # if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
 _GL_FUNCDECL_SYS (waitpid, pid_t, (pid_t pid, int *statusp, int options));
 # endif

diff --git a/m4/sys_wait_h.m4 b/m4/sys_wait_h.m4
index dd44581d558367824eb2fbb0def592ebc8d54420..63e1d21e4a1901e65b2b4ded9ad57f88287a9aa0 100644 (file)
--- a/m4/sys_wait_h.m4
+++ b/m4/sys_wait_h.m4
@@ -22,9 +22,12 @@ AC_DEFUN([gl_SYS_WAIT_MODULE_INDICATOR],
   dnl Use AC_REQUIRE here, so that the default settings are expanded once only.
   AC_REQUIRE([gl_SYS_WAIT_H_DEFAULTS])
   gl_MODULE_INDICATOR_SET_VARIABLE([$1])
+  dnl Define it also as a C macro, for the benefit of the unit tests.
+  gl_MODULE_INDICATOR_FOR_TESTS([$1])
 ])
 
 AC_DEFUN([gl_SYS_WAIT_H_DEFAULTS],
 [
+  GNULIB_WAITPID=0; AC_SUBST([GNULIB_WAITPID])
   dnl Assume proper GNU behavior unless another module says otherwise.
 ])

diff --git a/modules/grantpt b/modules/grantpt
index 4a2e16809ce3456d7d8b1ef4e4c2fbf9a596488c..a5d9eb40342cb08678e0334f2f224c28f431a760 100644 (file)
--- a/modules/grantpt
+++ b/modules/grantpt
@@ -9,6 +9,7 @@ Depends-on:
 stdlib
 extensions
 pt_chown
+waitpid
 configmake
 
 configure.ac:

diff --git a/modules/sys_wait b/modules/sys_wait
index 2c82029711e9120344280b17cae412bfded47388..01f995e87ce551d07e956002dfc0749bb612d22c 100644 (file)
--- a/modules/sys_wait
+++ b/modules/sys_wait
@@ -9,7 +9,6 @@ Depends-on:
 c++defs
 include_next
 warn-on-use
-waitpid
 
 configure.ac:
 gl_SYS_WAIT_H
@@ -27,6 +26,7 @@ sys/wait.h: sys_wait.in.h $(CXXDEFS_H) $(WARN_ON_USE_H)
          sed -e 's|@''INCLUDE_NEXT''@|$(INCLUDE_NEXT)|g' \
              -e 's|@''PRAGMA_SYSTEM_HEADER''@|@PRAGMA_SYSTEM_HEADER@|g' \
              -e 's|@''NEXT_SYS_WAIT_H''@|$(NEXT_SYS_WAIT_H)|g' \
+             -e 's|@''GNULIB_WAITPID''@|$(GNULIB_WAITPID)|g' \
              -e '/definitions of _GL_FUNCDECL_RPL/r $(CXXDEFS_H)' \
              -e '/definition of _GL_WARN_ON_USE/r $(WARN_ON_USE_H)' \
              < $(srcdir)/sys_wait.in.h; \

diff --git a/modules/wait-process b/modules/wait-process
index 0670bda8666044e3c954e9a7fa0d6323a206fa47..9120bbcf0a6f5541ef80b85faf133f3955f96991 100644 (file)
--- a/modules/wait-process
+++ b/modules/wait-process
@@ -17,6 +17,7 @@ stdbool
 sys_wait
 unistd
 atexit
+waitpid
 
 configure.ac:
 gl_WAIT_PROCESS

diff --git a/modules/waitpid b/modules/waitpid
index f8fbf0f7618d71e144e409da7fa0405324750d09..f9699c6c5f915ccacae589188469a5535d486fd5 100644 (file)
--- a/modules/waitpid
+++ b/modules/waitpid
@@ -10,6 +10,7 @@ sys_wait
 
 configure.ac:
 gl_FUNC_WAITPID
+gl_SYS_WAIT_MODULE_INDICATOR([waitpid])
 
 Makefile.am:
 

diff --git a/tests/test-sys_wait-c++.cc b/tests/test-sys_wait-c++.cc
index 6216375d6187b9ba00ff7a87aa8a6e29692368c8..692e195242e42f2e577ddc97185d554d65d6746f 100644 (file)
--- a/tests/test-sys_wait-c++.cc
+++ b/tests/test-sys_wait-c++.cc
@@ -24,7 +24,9 @@
 #include "signature.h"
 
 
+#if GNULIB_TEST_WAITPID
 SIGNATURE_CHECK (GNULIB_NAMESPACE::waitpid, pid_t, (pid_t, int *, int));
+#endif
 
 
 int