Don't include <config.h> twice; this doesn't work in some cases,

e.g., when config.h has "#define intmax_t long long int" and
we include <config.h>, <inttypes.h>, <config.h> in that order.
* fprintftime.c: Don't include config.h or fprintftime.h.
* fts-cycle.c: Don't include config.h.
* strftime.c: Include fprintftime.h if FPRINTFTIME is defined.
* xstrtoimax.c: Remove copyright notice since it's short tnow.
Don't include config.h or xstrtol.h.  Define STRTOL_T_MINIMUM
and STRTOL_T_MAXIMUM unconditionally, since we now assume gnulib
inttypes.h.
* xstrtoumax.c: Likewise.
* xstrtol.c: Include config.h and xstrtol.h after defining
__strtol and the like, so that this module is more like its siblings.
(STRTOL_T_MINIMUM, STRTOL_T_MAXIMUM) [! defined STRTOL_T_MINIMUM]:
Remove; no longer needed now that we assume gnulib inttypes.h.

2006-10-07  Bruno Haible  <bruno@clisp.org>

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 4002832c387b75caed455bca6f28a90a1fab5109..08fc829ca22ffbb3208e2cc2cb85cb0e74af5640 100644 (file)
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,4 +1,22 @@
-2006-10-03  Bruno Haible  <bruno@clisp.org>
+2006-10-08  Paul Eggert  <eggert@cs.ucla.edu>
+
+       Don't include <config.h> twice; this doesn't work in some cases,
+       e.g., when config.h has "#define intmax_t long long int" and
+       we include <config.h>, <inttypes.h>, <config.h> in that order.
+       * fprintftime.c: Don't include config.h or fprintftime.h.
+       * fts-cycle.c: Don't include config.h.
+       * strftime.c: Include fprintftime.h if FPRINTFTIME is defined.
+       * xstrtoimax.c: Remove copyright notice since it's short tnow.
+       Don't include config.h or xstrtol.h.  Define STRTOL_T_MINIMUM
+       and STRTOL_T_MAXIMUM unconditionally, since we now assume gnulib
+       inttypes.h.
+       * xstrtoumax.c: Likewise.
+       * xstrtol.c: Include config.h and xstrtol.h after defining
+       __strtol and the like, so that this module is more like its siblings.
+       (STRTOL_T_MINIMUM, STRTOL_T_MAXIMUM) [! defined STRTOL_T_MINIMUM]:
+       Remove; no longer needed now that we assume gnulib inttypes.h.
+
+2006-10-07  Bruno Haible  <bruno@clisp.org>
 
        * gl_sublist.h: New file.
        * gl_sublist.c: New file.

diff --git a/lib/fprintftime.c b/lib/fprintftime.c
index 2a455275b7efbb04356e26588f60b229e6c2563a..e6eb4f20f5a3648aee5ecf3cc4edee18a60acf57 100644 (file)
--- a/lib/fprintftime.c
+++ b/lib/fprintftime.c
@@ -1,5 +1,2 @@
-#include <config.h>
-
-#include "fprintftime.h"
 #define FPRINTFTIME 1
 #include "strftime.c"

diff --git a/lib/fts-cycle.c b/lib/fts-cycle.c
index a5f38ab27d90ec0c2ee43cf6fa8c9695e5cd9375..8edf26ee4d5c90deb79390d95b75825d9c5485b9 100644 (file)
--- a/lib/fts-cycle.c
+++ b/lib/fts-cycle.c
@@ -18,8 +18,6 @@
    along with this program; if not, write to the Free Software Foundation,
    Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.  */
 
-#include <config.h>
-
 #include "cycle-check.h"
 #include "hash.h"
 

diff --git a/lib/strftime.c b/lib/strftime.c
index 86cd1cf7e7082ef78d6dcd070c8f3719e52cb145..ffa51c0cc3f2a1aedff2a48bb582c1c48d9c0ed8 100644 (file)
--- a/lib/strftime.c
+++ b/lib/strftime.c
@@ -30,6 +30,9 @@
 # include "../locale/localeinfo.h"
 #else
 # include <config.h>
+# if FPRINTFTIME
+#  include "fprintftime.h"
+# endif
 #endif
 
 #include <ctype.h>

diff --git a/lib/xstrtoimax.c b/lib/xstrtoimax.c
index 37b30d886d293c8a57e48192bcee3ff13181c04d..b4baf5bc60a1395b12c17821d2fcfa8af221f408 100644 (file)
--- a/lib/xstrtoimax.c
+++ b/lib/xstrtoimax.c
@@ -1,32 +1,6 @@
-/* xstrtoimax.c -- A more useful interface to strtoimax.
-
-   Copyright (C) 2001, 2003, 2004, 2006 Free Software Foundation, Inc.
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2, or (at your option)
-   any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software Foundation,
-   Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.  */
-
-/* Cloned by Jim Meyering. */
-
-#include <config.h>
-
-#include "xstrtol.h"
-
 #define __strtol strtoimax
 #define __strtol_t intmax_t
 #define __xstrtol xstrtoimax
-#ifdef INTMAX_MAX
-# define STRTOL_T_MINIMUM INTMAX_MIN
-# define STRTOL_T_MAXIMUM INTMAX_MAX
-#endif
+#define STRTOL_T_MINIMUM INTMAX_MIN
+#define STRTOL_T_MAXIMUM INTMAX_MAX
 #include "xstrtol.c"

diff --git a/lib/xstrtol.c b/lib/xstrtol.c
index 2d1ba91543b14d271ae1b32b893e67e22edde94b..c4557a00640a70f9d420edc72ad099204ac283bf 100644 (file)
--- a/lib/xstrtol.c
+++ b/lib/xstrtol.c
@@ -19,10 +19,6 @@
 
 /* Written by Jim Meyering. */
 
-#include <config.h>
-
-#include "xstrtol.h"
-
 #ifndef __strtol
 # define __strtol strtol
 # define __strtol_t long int
@@ -31,6 +27,10 @@
 # define STRTOL_T_MAXIMUM LONG_MAX
 #endif
 
+#include <config.h>
+
+#include "xstrtol.h"
+
 /* Some pre-ANSI implementations (e.g. SunOS 4)
    need stderr defined if assertion checking is enabled.  */
 #include <stdio.h>
@@ -44,19 +44,6 @@
 
 #include "intprops.h"
 
-#ifndef STRTOL_T_MINIMUM
-# define STRTOL_T_MINIMUM TYPE_MINIMUM (__strtol_t)
-# define STRTOL_T_MAXIMUM TYPE_MAXIMUM (__strtol_t)
-#endif
-
-#if !HAVE_DECL_STRTOIMAX && !defined strtoimax
-intmax_t strtoimax ();
-#endif
-
-#if !HAVE_DECL_STRTOUMAX && !defined strtoumax
-uintmax_t strtoumax ();
-#endif
-
 static strtol_error
 bkm_scale (__strtol_t *x, int scale_factor)
 {

diff --git a/lib/xstrtoumax.c b/lib/xstrtoumax.c
index 6fb35c7525a1bc25e42dde1140f296a729822265..9a2349f00d36e1e6aa72b45ea8cf54c76de6924c 100644 (file)
--- a/lib/xstrtoumax.c
+++ b/lib/xstrtoumax.c
@@ -1,32 +1,6 @@
-/* xstrtoumax.c -- A more useful interface to strtoumax.
-
-   Copyright (C) 1999, 2003, 2004, 2006 Free Software Foundation, Inc.
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2, or (at your option)
-   any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software Foundation,
-   Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.  */
-
-/* Written by Paul Eggert. */
-
-#include <config.h>
-
-#include "xstrtol.h"
-
 #define __strtol strtoumax
 #define __strtol_t uintmax_t
 #define __xstrtol xstrtoumax
-#ifdef UINTMAX_MAX
-# define STRTOL_T_MINIMUM 0
-# define STRTOL_T_MAXIMUM UINTMAX_MAX
-#endif
+#define STRTOL_T_MINIMUM 0
+#define STRTOL_T_MAXIMUM UINTMAX_MAX
 #include "xstrtol.c"