Fix test of fcntl's return value.

diff --git a/ChangeLog b/ChangeLog
index c475641524f43cfc906efd80c3539629203e7420..868272b551eea51828b46d9a5d52250c367ac4b4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2009-08-23  Bruno Haible  <bruno@clisp.org>
+
+       * lib/pipe2.c (pipe2): Fix test of fcntl's return value.
+
 2009-08-23  Bruno Haible  <bruno@clisp.org>
 
        * modules/fchdir (Depends-on): Use fcntl-h instead of fcntl.

diff --git a/lib/pipe2.c b/lib/pipe2.c
index 68677deac2dc3bb44386ec51b8ad6f1d152c66ff..d40c4cda8e8d6f88b71b1309b47727ed5ead0231 100644 (file)
--- a/lib/pipe2.c
+++ b/lib/pipe2.c
@@ -70,9 +70,9 @@ pipe2 (int fd[2], int flags)
       int fcntl_flags;
 
       if ((fcntl_flags = fcntl (fd[1], F_GETFL, 0)) < 0
-         || fcntl (fd[1], F_SETFL, fcntl_flags | O_NONBLOCK) < 0
+         || fcntl (fd[1], F_SETFL, fcntl_flags | O_NONBLOCK) == -1
          || (fcntl_flags = fcntl (fd[0], F_GETFL, 0)) < 0
-         || fcntl (fd[0], F_SETFL, fcntl_flags | O_NONBLOCK) < 0)
+         || fcntl (fd[0], F_SETFL, fcntl_flags | O_NONBLOCK) == -1)
        goto fail;
     }
 
@@ -81,9 +81,9 @@ pipe2 (int fd[2], int flags)
       int fcntl_flags;
 
       if ((fcntl_flags = fcntl (fd[1], F_GETFD, 0)) < 0
-         || fcntl (fd[1], F_SETFD, fcntl_flags | FD_CLOEXEC) < 0
+         || fcntl (fd[1], F_SETFD, fcntl_flags | FD_CLOEXEC) == -1
          || (fcntl_flags = fcntl (fd[0], F_GETFD, 0)) < 0
-         || fcntl (fd[0], F_SETFD, fcntl_flags | FD_CLOEXEC) < 0)
+         || fcntl (fd[0], F_SETFD, fcntl_flags | FD_CLOEXEC) == -1)
        goto fail;
     }