perror: call strerror_r directly

No need to make a wrapper that burns static storage when we can
just use stack storage.

* modules/perror (Files): Drop strerror-impl.h.
* lib/perror.c (perror): Use our own stack buffer, rather than
calling a wrapper that uses static storage.
* doc/posix-functions/perror.texi (perror): Document a limitation
of our replacement.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index f62e43b6e3434340980ef61d27dc741161cf0b04..0685dccc5a2066ba971fef2761a1021ad8390c74 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2011-06-01  Eric Blake  <eblake@redhat.com>
 
+       perror: call strerror_r directly
+       * modules/perror (Files): Drop strerror-impl.h.
+       * lib/perror.c (perror): Use our own stack buffer, rather than
+       calling a wrapper that uses static storage.
+       * doc/posix-functions/perror.texi (perror): Document a limitation
+       of our replacement.
+
        strerror_r: fix includes for FreeBSD
        * lib/strerror_r.c (includes): Use <stdlib.h> unconditionally,
        since we use abort on some platforms.

diff --git a/doc/posix-functions/perror.texi b/doc/posix-functions/perror.texi
index cf6ac79d1c9568302a740582b82d5226926da167..167cf39aea9dbe311f2517531d174d9ca665b3de 100644 (file)
--- a/doc/posix-functions/perror.texi
+++ b/doc/posix-functions/perror.texi
@@ -24,4 +24,8 @@ Portability problems not fixed by Gnulib:
 POSIX requires that this function set the stream error bit (detected
 by @code{ferror}) on write failure, but not all platforms do this:
 glibc 2.13.
+@item
+POSIX requires that this function not alter stream orientation, but
+the gnulib replacement locks in byte orientation and fails on wide
+character streams.
 @end itemize

diff --git a/lib/perror.c b/lib/perror.c
index 29af3c5a56c6d7b8df76859d62c4e64f72442554..88981d165826ca2789d130e9b02e5367ba177165 100644 (file)
--- a/lib/perror.c
+++ b/lib/perror.c
@@ -40,10 +40,18 @@
 void
 perror (const char *string)
 {
-  const char *errno_description = my_strerror (errno);
+  char stackbuf[256];
+  int ret;
+
+  /* Our implementation guarantees that this will be a non-empty
+     string, even if it returns EINVAL; and stackbuf should be sized
+     large enough to avoid ERANGE.  */
+  ret = strerror_r (errno, stackbuf, sizeof stackbuf);
+  if (ret == ERANGE)
+    abort ();
 
   if (string != NULL && *string != '\0')
-    fprintf (stderr, "%s: %s\n", string, errno_description);
+    fprintf (stderr, "%s: %s\n", string, stackbuf);
   else
-    fprintf (stderr, "%s\n", errno_description);
+    fprintf (stderr, "%s\n", stackbuf);
 }

diff --git a/modules/perror b/modules/perror
index 1ff9ec27e54a4d103435488187ff6d8750cf22fa..38e28ce6338efc857f4e8f814fb30823546b69e2 100644 (file)
--- a/modules/perror
+++ b/modules/perror
@@ -3,7 +3,6 @@ perror() function: print a message describing error code.
 
 Files:
 lib/perror.c
-lib/strerror-impl.h
 m4/perror.m4
 
 Depends-on: