More memcmp tests.

diff --git a/ChangeLog b/ChangeLog
index f80ec3c3b716c7b53803eebdc00f67f702e13d9d..b4ac63656f1dc5ad475790e5cf16d50975bf9cf9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-05-20  Bruno Haible  <bruno@clisp.org>
+
+       * tests/test-memcmp.c (main): Test also the sign of the result. Test
+       against two known bugs; code taken from autoconf's AC_FUNC_MEMCMP.
+
 2008-05-20  Simon Josefsson  <simon@josefsson.org>
 
        * modules/memcmp-tests: New file.

diff --git a/tests/test-memcmp.c b/tests/test-memcmp.c
index 28c8fb00b98d69eb881726ed948d4fe232dd5450..5c2ac29d884d560fe82b6b0bb9bfbf61817f5048 100644 (file)
--- a/tests/test-memcmp.c
+++ b/tests/test-memcmp.c
@@ -37,16 +37,44 @@
 int
 main (void)
 {
-  char foo[] = "foo";
-  char foobar[] = "foobar";
-  char bar[] = "bar";
-
+  /* Test equal / not equal distinction.  */
   ASSERT (memcmp (NULL, NULL, 0) == 0);
-  ASSERT (memcmp (foo, foobar, 2) == 0);
-  ASSERT (memcmp (foo, foobar, 3) == 0);
-  ASSERT (memcmp (foo, foobar, 4) != 0);
-  ASSERT (memcmp (foo, bar, 1) != 0);
-  ASSERT (memcmp (foo, bar, 3) != 0);
+  ASSERT (memcmp ("foo", "foobar", 2) == 0);
+  ASSERT (memcmp ("foo", "foobar", 3) == 0);
+  ASSERT (memcmp ("foo", "foobar", 4) != 0);
+  ASSERT (memcmp ("foo", "bar", 1) != 0);
+  ASSERT (memcmp ("foo", "bar", 3) != 0);
+
+  /* Test less / equal / greater distinction.  */
+  ASSERT (memcmp ("foo", "moo", 4) < 0);
+  ASSERT (memcmp ("moo", "foo", 4) > 0);
+  ASSERT (memcmp ("oomph", "oops", 3) < 0);
+  ASSERT (memcmp ("oops", "oomph", 3) > 0);
+  ASSERT (memcmp ("foo", "foobar", 4) < 0);
+  ASSERT (memcmp ("foobar", "foo", 4) > 0);
+
+  /* Some old versions of memcmp were not 8-bit clean.  */
+  ASSERT (memcmp ("\100", "\201", 1) < 0);
+  ASSERT (memcmp ("\201", "\100", 1) > 0);
+  ASSERT (memcmp ("\200", "\201", 1) < 0);
+  ASSERT (memcmp ("\201", "\200", 1) > 0);
+
+  /* The Next x86 OpenStep bug shows up only when comparing 16 bytes
+     or more and with at least one buffer not starting on a 4-byte boundary.
+     William Lewis provided this test program.   */
+  {
+    char foo[21];
+    char bar[21];
+    int i;
+    for (i = 0; i < 4; i++)
+      {
+       char *a = foo + i;
+       char *b = bar + i;
+       strcpy (a, "--------01111111");
+       strcpy (b, "--------10000000");
+       ASSERT (memcmp (a, b, 16) < 0);
+      }
+  }
 
   return 0;
 }