pipe2: Remove dependency on 'nonblocking' module.

* lib/pipe2.c: Include verify.h. Include nonblocking.h only if
O_NONBLOCK is defined by gnulib.
(pipe2) [WIN32]: If O_NONBLOCK is not defined by gnulib, verify that it
is zero.
* modules/pipe2 (Depends-on): Add verify. Remove nonblocking.
* tests/test-pipe2.c: Include nonblocking.h only if O_NONBLOCK is
defined by gnulib.
(get_nonblocking_flag): New function.
(main): Test O_NONBLOCK flag only if it is nonzero.

diff --git a/ChangeLog b/ChangeLog
index fbd5ccd3b4f1ad106ef8c42d717172e0fdf30bb6..ae8383c4f2670b6144c91566c87b7240d01dc8e1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2011-06-02  Bruno Haible  <bruno@clisp.org>
+
+       pipe2: Remove dependency on 'nonblocking' module.
+       * lib/pipe2.c: Include verify.h. Include nonblocking.h only if
+       O_NONBLOCK is defined by gnulib.
+       (pipe2) [WIN32]: If O_NONBLOCK is not defined by gnulib, verify that it
+       is zero.
+       * modules/pipe2 (Depends-on): Add verify. Remove nonblocking.
+       * tests/test-pipe2.c: Include nonblocking.h only if O_NONBLOCK is
+       defined by gnulib.
+       (get_nonblocking_flag): New function.
+       (main): Test O_NONBLOCK flag only if it is nonzero.
+       * doc/glibc-functions/pipe2.texi: Mention the 'nonblocking' module.
+
 2011-06-03  Jim Meyering  <meyering@redhat.com>
 
        maint: three new prohibit-header-without-use rules

diff --git a/doc/glibc-functions/pipe2.texi b/doc/glibc-functions/pipe2.texi
index f33d90d48a6c6226f3246f8ed09f638dca6885d5..5721ae9b98473c3cf1304f7f6377089057623401 100644 (file)
--- a/doc/glibc-functions/pipe2.texi
+++ b/doc/glibc-functions/pipe2.texi
@@ -15,3 +15,6 @@ IRIX 6.5, OSF/1 5.1, Solaris 11 2010-11, Cygwin 1.7.1, mingw, Interix 3.5, BeOS.
 Portability problems not fixed by Gnulib:
 @itemize
 @end itemize
+
+Note: This function portably supports the @code{O_NONBLOCK} flag only if the
+gnulib module @code{nonblocking} is also used.

diff --git a/lib/pipe2.c b/lib/pipe2.c
index 18098c4b4ec93e8e624216dff2ba983709a7eaf7..f50dae6650a5ce2ff54ca4856b7ea6693b7242bd 100644 (file)
--- a/lib/pipe2.c
+++ b/lib/pipe2.c
@@ -24,7 +24,11 @@
 #include <fcntl.h>
 
 #include "binary-io.h"
-#include "nonblocking.h"
+#include "verify.h"
+
+#if GNULIB_defined_O_NONBLOCK
+# include "nonblocking.h"
+#endif
 
 #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
 /* Native Woe32 API.  */
@@ -69,12 +73,19 @@ pipe2 (int fd[2], int flags)
   if (_pipe (fd, 4096, flags & ~O_NONBLOCK) < 0)
     return -1;
 
+  /* O_NONBLOCK handling.
+     On native Windows platforms, O_NONBLOCK is defined by gnulib.  Use the
+     functions defined by the gnulib module 'nonblocking'.  */
+# if GNULIB_defined_O_NONBLOCK
   if (flags & O_NONBLOCK)
     {
       if (set_nonblocking_flag (fd[0], true) != 0
           || set_nonblocking_flag (fd[1], true) != 0)
         goto fail;
     }
+# else
+  verify (O_NONBLOCK == 0);
+# endif
 
   return 0;
 
@@ -88,6 +99,8 @@ pipe2 (int fd[2], int flags)
      says that initially, the O_NONBLOCK and FD_CLOEXEC flags are cleared on
      both fd[0] and fd[1].  */
 
+  /* O_NONBLOCK handling.
+     On Unix platforms, O_NONBLOCK is defined by the system.  Use fcntl().  */
   if (flags & O_NONBLOCK)
     {
       int fcntl_flags;

diff --git a/modules/pipe2 b/modules/pipe2
index ca722168a7536d107b0afeb626bfb0685da2fdc3..62872a22551b3283220aa640ed513a7340c30402 100644 (file)
--- a/modules/pipe2
+++ b/modules/pipe2
@@ -10,7 +10,7 @@ unistd
 fcntl-h
 binary-io
 extensions
-nonblocking
+verify
 
 configure.ac:
 gl_FUNC_PIPE2

diff --git a/tests/test-pipe2.c b/tests/test-pipe2.c
index 8ca8e013633be27aee319cd21bb6533b2e4b1efb..d83162c2f5868b99260215bfa2041833ff5f5197 100644 (file)
--- a/tests/test-pipe2.c
+++ b/tests/test-pipe2.c
@@ -33,7 +33,9 @@ SIGNATURE_CHECK (pipe2, int, (int[2], int));
 
 #include "binary-io.h"
 #include "macros.h"
-#include "nonblocking.h"
+#if GNULIB_NONBLOCKING
+# include "nonblocking.h"
+#endif
 
 /* Return true if FD is open.  */
 static bool
@@ -68,13 +70,30 @@ is_cloexec (int fd)
 #endif
 }
 
+#if ! GNULIB_NONBLOCKING
+static int
+get_nonblocking_flag (int fd)
+{
+# if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
+  return 0;
+# else
+#  ifndef F_GETFL
+#   error Please port fcntl to your platform
+#  endif
+  int flags;
+  ASSERT ((flags = fcntl (fd, F_GETFL)) >= 0);
+  return (flags & O_NONBLOCK) != 0;
+# endif
+}
+#endif
+
 int
 main ()
 {
   int use_nonblocking;
   int use_cloexec;
 
-  for (use_nonblocking = 0; use_nonblocking <= 1; use_nonblocking++)
+  for (use_nonblocking = 0; use_nonblocking <= !!O_NONBLOCK; use_nonblocking++)
     for (use_cloexec = 0; use_cloexec <= !!O_CLOEXEC; use_cloexec++)
       {
         int o_flags;