Fixed incorrect syntax generated by the Select Random Cases dialog.

Reported by: Eric E Graig

diff --git a/NEWS b/NEWS
index 2c07d2a4161e4383d73b95accb5bdaed3d103938..2048f8c4346232ec180988c6ce5693da4f3a6428 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,9 @@ Please send PSPP bug reports to bug-gnu-pspp@gnu.org.
 
 Changes from 1.2.0 to 1.3.0:
 
+ * A bug where the Data|Select Cases|Random Sample menu would generate
+   invalid syntax has been fixed.
+
  * FREQUENCIES will emit a warning if one or more weight values are missing.
 
  * Plain text output is no longer divided into pages, since it is now

diff --git a/src/ui/gui/psppire-dialog-action-select.c b/src/ui/gui/psppire-dialog-action-select.c
index e5d777dadac61363493c3801121fd00f57ddb9f3..ee45db152e62e59a0b95752c622e751e49e88f61 100644 (file)
--- a/src/ui/gui/psppire-dialog-action-select.c
+++ b/src/ui/gui/psppire-dialog-action-select.c
@@ -414,7 +414,7 @@ generate_syntax_filter (const PsppireDialogAction *a)
                           ranvar);
 
          ds_put_c_format (&dss,
-                          "SORT BY %s, %s.\n",
+                          "SORT CASES BY %s, %s.\n",
                           filter, ranvar);
 
          ds_put_cstr (&dss, "EXECUTE.\n");
@@ -434,7 +434,7 @@ generate_syntax_filter (const PsppireDialogAction *a)
 
 
          ds_put_c_format (&dss,
-                          "SORT BY %s.\n",
+                          "SORT CASES BY %s.\n",
                           key);
 
          ds_put_c_format (&dss,