init.sh: simply unset TMPDIR rather than risking env -i

* tests/init.sh (mktempd_): Using env -i is rather harsh, and
although it probably works fine on all Unix-based systems, some
systems (Cygwin?) cannot tolerate a totally cleared environment.
Suggestion from Eric Blake.

2010-04-06  Jim Meyering  <meyering@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 60fb41354a9e93cc8506b5984d31455eb55c175c..59cec392f9ff57b3589a69810297be4f9ccd8273 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2010-04-06  Jim Meyering  <meyering@redhat.com>
+
+       init.sh: simply unset TMPDIR rather than risking env -i
+       * tests/init.sh (mktempd_): Using env -i is rather harsh, and
+       although it probably works fine on all Unix-based systems, some
+       systems (Cygwin?) cannot tolerate a totally cleared environment.
+       Suggestion from Eric Blake.
+
 2010-04-06  Jim Meyering  <meyering@redhat.com>
 
        init.sh: portability fix: use env's POSIX-specified -i option not -u

diff --git a/tests/init.sh b/tests/init.sh
index 9b651292220326c16391c9fe918a90e1ffba8615..abfa3b3c31d2c898768c40bfe6709c2cd61d6bdb 100644 (file)
--- a/tests/init.sh
+++ b/tests/init.sh
@@ -306,7 +306,7 @@ mktempd_()
   fail=0
 
   # First, try to use mktemp.
-  d=`env -i PATH="$PATH" mktemp -d -t -p "$destdir_" "$template_" 2>/dev/null` \
+  d=`unset TMPDIR; mktemp -d -t -p "$destdir_" "$template_" 2>/dev/null` \
     || fail=1
 
   # The resulting name must be in the specified directory.