Fix some incompatibilities with gcc -ansi -pedantic.

* lib/regex.h (__restrict_arr): Don't use the [restrict] syntax
if compiling pedantically with GCC, unless it's C99 or later.
Don't trust sys/cdefs.h's definition of __restrict_arr, either, as
it mishandles gcc -ansi -pedantic as well.
* lib/regex_internal.h (re_token_t): Don't use enum bitfields
if gcc -pedantic.
* lib/regexec.c (check_node_accept_bytes): Don't use auto
initializers for struct if -pedantic, unless it's C99 or later.

diff --git a/ChangeLog b/ChangeLog
index e1c6dcfb87348999d1bc5588cb2419aaf7486136..3fa63a7162635aaf6288f03e195e87da96ac3d0e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2006-11-26  Paul Eggert  <eggert@cs.ucla.edu>
+
+       Fix some incompatibilities with gcc -ansi -pedantic.
+       * lib/regex.h (__restrict_arr): Don't use the [restrict] syntax
+       if compiling pedantically with GCC, unless it's C99 or later.
+       Don't trust sys/cdefs.h's definition of __restrict_arr, either, as
+       it mishandles gcc -ansi -pedantic as well.
+       * lib/regex_internal.h (re_token_t): Don't use enum bitfields
+       if gcc -pedantic.
+       * lib/regexec.c (check_node_accept_bytes): Don't use auto
+       initializers for struct if -pedantic, unless it's C99 or later.
+
 2006-11-25  Nix  <nix@esperi.org.uk>  (tiny change)
 
        * m4/fcntl_h.m4 (gl_FCNTL_H): Test the atime, not the mtime.

diff --git a/lib/regex.h b/lib/regex.h
index e8748e195be85b981db37885101fe09481ceb329..621bffb516aafb153cd0811403f4d24bd88470a4 100644 (file)
--- a/lib/regex.h
+++ b/lib/regex.h
@@ -635,14 +635,17 @@ extern int re_exec (const char *);
 #  endif
 # endif
 #endif
-/* gcc 3.1 and up support the [restrict] syntax.  */
-#ifndef __restrict_arr
-# if (__GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 1)) \
-     && !defined __GNUG__
-#  define __restrict_arr __restrict
-# else
-#  define __restrict_arr
-# endif
+/* gcc 3.1 and up support the [restrict] syntax.  Don't trust
+   sys/cdefs.h's definition of __restrict_arr, though, as it
+   mishandles gcc -ansi -pedantic.  */
+#undef __restrict_arr
+#if (defined __GNUG__                          \
+     || (__STDC_VERSION__ < 199901L            \
+        && (__STRICT_ANSI__                    \
+            || (__GNUC__ < 3 || (__GNUC__ == 3 && __GNUC_MINOR__ < 1)))))
+# define __restrict_arr
+#else
+# define __restrict_arr __restrict
 #endif
 
 /* POSIX compatibility.  */

diff --git a/lib/regex_internal.h b/lib/regex_internal.h
index cc9b5b79c2cfb055c6c4e358269808e07170dad2..9a978b2a9f9ba6d9b7a893472ae54a7d7034598b 100644 (file)
--- a/lib/regex_internal.h
+++ b/lib/regex_internal.h
@@ -348,7 +348,7 @@ typedef struct
     Idx idx;                   /* for BACK_REF */
     re_context_type ctx_type;  /* for ANCHOR */
   } opr;
-#if __GNUC__ >= 2
+#if __GNUC__ >= 2 && !__STRICT_ANSI__
   re_token_type_t type : 8;
 #else
   re_token_type_t type;

diff --git a/lib/regexec.c b/lib/regexec.c
index 84c3aed634997347fd6c121ae9d2918832f2cb9a..7c186aa2077bfe98f27f4ccf95eea9b4972ef532 100644 (file)
--- a/lib/regexec.c
+++ b/lib/regexec.c
@@ -3966,7 +3966,7 @@ check_node_accept_bytes (const re_dfa_t *dfa, Idx node_idx,
 # endif /* _LIBC */
        {
          /* match with range expression?  */
-#if __GNUC__ >= 2
+#if __GNUC__ >= 2 && ! (__STDC_VERSION__ < 199901L && __STRICT_ANSI__)
          wchar_t cmp_buf[] = {L'\0', L'\0', wc, L'\0', L'\0', L'\0'};
 #else
          wchar_t cmp_buf[] = {L'\0', L'\0', L'\0', L'\0', L'\0', L'\0'};