odp-util: Use nl_parse_nested() to simplify format_odp_sample_action().
authorBen Pfaff <blp@nicira.com>
Tue, 4 Oct 2011 19:58:25 +0000 (12:58 -0700)
committerBen Pfaff <blp@nicira.com>
Wed, 5 Oct 2011 18:17:14 +0000 (11:17 -0700)
lib/odp-util.c

index d97d30c038dca63c6c1c311a4235e63f125f6485..7f5158fe90f32764823d2411d7891d29de016376 100644 (file)
@@ -98,16 +98,13 @@ format_odp_sample_action(struct ds *ds, const struct nlattr *attr)
         [OVS_SAMPLE_ATTR_ACTIONS] = { .type = NL_A_NESTED }
     };
     struct nlattr *a[ARRAY_SIZE(ovs_sample_policy)];
-    struct ofpbuf buf;
     double percentage;
     const struct nlattr *nla_acts;
     int len;
 
     ds_put_cstr(ds, "sample");
 
-    ofpbuf_use_const(&buf, nl_attr_get(attr), nl_attr_get_size(attr));
-    if (!nl_policy_parse(&buf, 0, ovs_sample_policy, a,
-                            ARRAY_SIZE(ovs_sample_policy))) {
+    if (!nl_parse_nested(attr, ovs_sample_policy, a, ARRAY_SIZE(a))) {
         ds_put_cstr(ds, "(error)");
         return;
     }