ensure that return value of uinttostr et al are not ignored

* lib/inttostr.h (__GNUC_PREREQ): Define.
(__attribute_warn_unused_result__): Define.
(offtostr, imaxtostr, umaxtostr, uinttostr): Apply the attribute.

diff --git a/ChangeLog b/ChangeLog
index 8d9212256537782de70ec3a1992196464c067463..91f110697bf6779278a1a01e9d2b77e95019c572 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-08-10  Jim Meyering  <meyering@redhat.com>
+
+       ensure that return value of uinttostr et al are not ignored
+       * lib/inttostr.h (__GNUC_PREREQ): Define.
+       (__attribute_warn_unused_result__): Define.
+       (offtostr, imaxtostr, umaxtostr, uinttostr): Apply the attribute.
+
 2008-08-07  Paolo Bonzini  <bonzini@gnu.org>
 
        * lib/lock.c (glthread_recursive_lock_init_multithreaded)

diff --git a/lib/inttostr.h b/lib/inttostr.h
index aa5820fd5af33a0af04e82f646b5f62107d53447..a103caf587f1a4966888bc6aed4a983d34b4b194 100644 (file)
--- a/lib/inttostr.h
+++ b/lib/inttostr.h
@@ -23,7 +23,24 @@
 
 #include "intprops.h"
 
-char *offtostr (off_t, char *);
-char *imaxtostr (intmax_t, char *);
-char *umaxtostr (uintmax_t, char *);
-char *uinttostr (unsigned int, char *);
+#ifndef __GNUC_PREREQ
+# if defined __GNUC__ && defined __GNUC_MINOR__
+#  define __GNUC_PREREQ(maj, min) \
+         ((__GNUC__ << 16) + __GNUC_MINOR__ >= ((maj) << 16) + (min))
+# else
+#  define __GNUC_PREREQ(maj, min) 0
+# endif
+#endif
+
+#if __GNUC_PREREQ (3,4)
+# undef __attribute_warn_unused_result__
+# define __attribute_warn_unused_result__ \
+   __attribute__ ((__warn_unused_result__))
+#else
+# define __attribute_warn_unused_result__ /* empty */
+#endif
+
+char *offtostr (off_t, char *) __attribute_warn_unused_result__;
+char *imaxtostr (intmax_t, char *) __attribute_warn_unused_result__;
+char *umaxtostr (uintmax_t, char *) __attribute_warn_unused_result__;
+char *uinttostr (unsigned int, char *) __attribute_warn_unused_result__;