maint.mk: test further PATH_MAX issues

* top/maint.mk (sc_prohibit_path_max_array): Rename...
(sc_prohibit_path_max_allocation): ...and also test alloca.
Suggested by Jim Meyering.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 9648603057ad7bee49bdaeb9d20ad3e22d97c698..9d7a52e323890f506c273c7cad7cbf627a63d89f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-06-23  Eric Blake  <eblake@redhat.com>
+
+       maint.mk: test further PATH_MAX issues
+       * top/maint.mk (sc_prohibit_path_max_array): Rename...
+       (sc_prohibit_path_max_allocation): ...and also test alloca.
+       Suggested by Jim Meyering.
+
 2011-06-22  Eric Blake  <eblake@redhat.com>
 
        maint.mk: add syntax-check to avoid char[PATH_MAX]

diff --git a/top/maint.mk b/top/maint.mk
index 4408a4e5ea8a937fcaa9223903e4657685392213..766d9c9c83f4a9a868c0e9add25420b594aa1c91 100644 (file)
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1135,11 +1135,11 @@ sc_Wundef_boolean:
          $(_sc_search_regexp)
 
 # Even if you use pathmax.h to guarantee that PATH_MAX is defined, it might
-# not be constant.  In general, use PATH_MAX as a limit, not an array
-# allocation bound.
-sc_prohibit_path_max_array:
-       @prohibit='\[PATH''_MAX'                                        \
-       halt='Avoid arrays of size PATH_MAX'                            \
+# not be constant, or might overflow a stack.  In general, use PATH_MAX as
+# a limit, not an array or alloca size.
+sc_prohibit_path_max_allocation:
+       @prohibit='(\balloca *\([^)]*|\[[^]]*)PATH_MAX'                 \
+       halt='Avoid stack allocations of size PATH_MAX'                 \
          $(_sc_search_regexp)
 
 sc_vulnerable_makefile_CVE-2009-4029: