realloc: document portability problem

* doc/posix-functions/realloc.texi (realloc): Mention pitfalls of
passing 0 size to realloc.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 3bc92407382747daf705f3e67d05e5868a49fc65..58f81959cb1d54548a67d8275535ae08f88ce6bf 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-03-24  Eric Blake  <eblake@redhat.com>
+
+       realloc: document portability problem
+       * doc/posix-functions/realloc.texi (realloc): Mention pitfalls of
+       passing 0 size to realloc.
+
 2011-03-23  Ben Walton  <bwalton@artsci.utoronto.ca>
 
        doc: update users.txt

diff --git a/doc/posix-functions/realloc.texi b/doc/posix-functions/realloc.texi
index 2ff4e169c168e9c83b535eba99179258e6597116..12a9dc7c3f2f6bd9018077d735e581f8cd907141 100644 (file)
--- a/doc/posix-functions/realloc.texi
+++ b/doc/posix-functions/realloc.texi
@@ -16,6 +16,19 @@ mingw.
 
 Portability problems not fixed by Gnulib:
 @itemize
+@item
+It is not portable to call @code{realloc} with a size of 0.  With a
+NULL pointer argument, this is the same ambiguity as @code{malloc (0)}
+on whether a unique zero-size object is created.  With a non-NULL
+pointer argument, C99 requires that if @code{realloc (p, 0)} returns
+@code{NULL} then @code{p} is still valid.  Among implementations that
+obey C99, behavior varies on whether @code{realloc (p, 0)} always
+fails and leaves @code{p} valid, or usually succeeds and returns a
+unique zero-size object; either way, a program not suspecting these
+semantics will leak memory (either the still-valid @code{p}, or the
+non-NULL return value).  Meanwhile, several implementations violate
+C99, by always calling @code{free (p)} but returning NULL:
+glibc, Cygwin
 @end itemize
 
 Extension: Gnulib provides a module @samp{realloc-gnu} that substitutes a