trim: remove three superfluous assignments

* lib/trim.c (trim2): Remove three superfluous assignments
and correct brace positioning.

diff --git a/ChangeLog b/ChangeLog
index 9c8b3a9e388382a35dbf112e75bee31e595d39da..8bcf08756f0253c2f701db8f5698c6083a320181 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-05-29  Jim Meyering  <meyering@redhat.com>
+
+       trim: remove three superfluous assignments
+       * lib/trim.c (trim2): Remove three superfluous assignments
+       and correct brace positioning.
+
 2011-05-29  Bruno Haible  <bruno@clisp.org>
 
        wctype-h: Avoid namespace pollution on Solaris 2.6.

diff --git a/lib/trim.c b/lib/trim.c
index 6515cfaff2808583bfbcbbd2726c2aab070a003b..155063eed3ead1e5275c6059670cc278b2efb059 100644 (file)
--- a/lib/trim.c
+++ b/lib/trim.c
@@ -73,10 +73,7 @@ trim2 (const char *s, int how)
           for (; mbi_avail (i); mbi_advance (i))
             {
               if (state == 0 && mb_isspace (mbi_cur (i)))
-                {
-                  state = 0;
-                  continue;
-                }
+                continue;
 
               if (state == 0 && !mb_isspace (mbi_cur (i)))
                 {
@@ -85,10 +82,7 @@ trim2 (const char *s, int how)
                 }
 
               if (state == 1 && !mb_isspace (mbi_cur (i)))
-                {
-                  state = 1;
-                  continue;
-                }
+                continue;
 
               if (state == 1 && mb_isspace (mbi_cur (i)))
                 {
@@ -97,7 +91,7 @@ trim2 (const char *s, int how)
                 }
               else if (state == 2 && mb_isspace (mbi_cur (i)))
                 {
-                  state = 2;
+                  /* empty */
                 }
               else
                 {
@@ -114,18 +108,21 @@ trim2 (const char *s, int how)
       char *p;
 
       /* Trim leading whitespaces. */
-      if (how != TRIM_TRAILING) {
-        for (p = d; *p && isspace ((unsigned char) *p); p++)
-          ;
+      if (how != TRIM_TRAILING)
+        {
+          for (p = d; *p && isspace ((unsigned char) *p); p++)
+            ;
 
-        memmove (d, p, strlen (p) + 1);
-      }
+          memmove (d, p, strlen (p) + 1);
+        }
 
       /* Trim trailing whitespaces. */
-      if (how != TRIM_LEADING) {
-        for (p = d + strlen (d) - 1; p >= d && isspace ((unsigned char) *p); p--)
-          *p = '\0';
-      }
+      if (how != TRIM_LEADING)
+        {
+          for (p = d + strlen (d) - 1;
+               p >= d && isspace ((unsigned char) *p); p--)
+            *p = '\0';
+        }
     }
 
   return d;