openat: simplify use of at-func.c

* lib/at-func.c (includes): Include prerequisites here, to
simplify requirements on client files.
* lib/openat-priv.h: Add double-inclusion guard.
* lib/faccessat.c (includes): Simplify.
* lib/fchmodat.c (includes): Likewise.
* lib/fchownat.c (includes): Likewise.
* lib/mkdirat.c (includes): Likewise.
* lib/mkfifoat.c (includes): Likewise.
* lib/symlinkat.c (includes): Likewise.

Signed-off-by: Eric Blake <ebb9@byu.net>

diff --git a/ChangeLog b/ChangeLog
index 3e8e24b6e3b0b885e6fbf880144a8e4b718f3556..6b174801b2c6b6b058441162e51931c465e9d6e4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,16 @@
 2009-09-19  Eric Blake  <ebb9@byu.net>
 
+       openat: simplify use of at-func.c
+       * lib/at-func.c (includes): Include prerequisites here, to
+       simplify requirements on client files.
+       * lib/openat-priv.h: Add double-inclusion guard.
+       * lib/faccessat.c (includes): Simplify.
+       * lib/fchmodat.c (includes): Likewise.
+       * lib/fchownat.c (includes): Likewise.
+       * lib/mkdirat.c (includes): Likewise.
+       * lib/mkfifoat.c (includes): Likewise.
+       * lib/symlinkat.c (includes): Likewise.
+
        openat: allow return of fd 0
        * modules/chdir-long (Depends-on): Relax openat-safer to openat.
        * modules/save-cwd (Depends-on): Replace fcntl-safer with

diff --git a/lib/at-func.c b/lib/at-func.c
index 3188770c65fe2da485136ca967e3120b33779084..75c80d3c9f5c1cd9b994ee948e0d280a0fe40e4e 100644 (file)
--- a/lib/at-func.c
+++ b/lib/at-func.c
@@ -16,6 +16,11 @@
 
 /* written by Jim Meyering */
 
+#include "dirname.h" /* solely for definition of IS_ABSOLUTE_FILE_NAME */
+#include "openat.h"
+#include "openat-priv.h"
+#include "save-cwd.h"
+
 #ifdef AT_FUNC_USE_F1_COND
 # define CALL_FUNC(F)                          \
   (flag == AT_FUNC_USE_F1_COND                 \

diff --git a/lib/faccessat.c b/lib/faccessat.c
index 42479c7fdfa3dd0278420a39f47ba8a93c28c569..de2dc2efd1d83165f7b881c30918e367356789e2 100644 (file)
--- a/lib/faccessat.c
+++ b/lib/faccessat.c
@@ -20,11 +20,6 @@
 
 #include <unistd.h>
 
-#include "dirname.h" /* solely for definition of IS_ABSOLUTE_FILE_NAME */
-#include "openat.h"
-#include "openat-priv.h"
-#include "save-cwd.h"
-
 #ifndef HAVE_ACCESS
 /* Mingw lacks access, but it also lacks real vs. effective ids, so
    the gnulib euidaccess module is good enough.  */

diff --git a/lib/fchmodat.c b/lib/fchmodat.c
index 53cafe06d5f5ab1d741895b5bd2a57a1b2c84714..55ae618365f6dc622681f95614bbbd3e07315364 100644 (file)
--- a/lib/fchmodat.c
+++ b/lib/fchmodat.c
@@ -20,10 +20,7 @@
 
 #include <sys/stat.h>
 
-#include "dirname.h" /* solely for definition of IS_ABSOLUTE_FILE_NAME */
-#include "openat.h"
-#include "openat-priv.h"
-#include "save-cwd.h"
+#include <errno.h>
 
 #ifndef HAVE_LCHMOD
 /* Use a different name, to avoid conflicting with any

diff --git a/lib/fchownat.c b/lib/fchownat.c
index 6da3537340c7f8daa12809fa4cd0afe1ee58f3bd..09b4aa8af6bf520bf5380651f88219254d2fbfe9 100644 (file)
--- a/lib/fchownat.c
+++ b/lib/fchownat.c
@@ -25,11 +25,6 @@
 
 #include <unistd.h>
 
-#include "dirname.h" /* solely for definition of IS_ABSOLUTE_FILE_NAME */
-#include "openat.h"
-#include "openat-priv.h"
-#include "save-cwd.h"
-
 /* Replacement for Solaris' function by the same name.
    Invoke chown or lchown on file, FILE, using OWNER and GROUP, in the
    directory open on descriptor FD.  If FLAG is AT_SYMLINK_NOFOLLOW, then

diff --git a/lib/mkdirat.c b/lib/mkdirat.c
index 33ece9ccd660161b575f0dee0251e5be66d07725..adb11f00e4d0c3440d04d24c195f2eecdc2a5199 100644 (file)
--- a/lib/mkdirat.c
+++ b/lib/mkdirat.c
@@ -20,11 +20,6 @@
 
 #include <unistd.h>
 
-#include "dirname.h" /* solely for definition of IS_ABSOLUTE_FILE_NAME */
-#include "openat.h"
-#include "openat-priv.h"
-#include "save-cwd.h"
-
 /* Solaris 10 has no function like this.
    Create a subdirectory, FILE, with mode MODE, in the directory
    open on descriptor FD.  If possible, do it without changing the

diff --git a/lib/mkfifoat.c b/lib/mkfifoat.c
index a230b0048a7b818629d19ed261bb4e6231aaefab..29fc070c68eed25fe8e06786784dc0d62134cbea 100644 (file)
--- a/lib/mkfifoat.c
+++ b/lib/mkfifoat.c
@@ -20,11 +20,6 @@
 
 #include <sys/stat.h>
 
-#include "dirname.h" /* solely for definition of IS_ABSOLUTE_FILE_NAME */
-#include "openat.h"
-#include "openat-priv.h"
-#include "save-cwd.h"
-
 #ifndef HAVE_MKFIFO
 # define HAVE_MKFIFO 0
 #endif

diff --git a/lib/openat-priv.h b/lib/openat-priv.h
index 2280416292d29075914ca15ab20e8e202a7ee197..fa286b50975dd91cce155eb68ddbd7c85b8a2f87 100644 (file)
--- a/lib/openat-priv.h
+++ b/lib/openat-priv.h
@@ -17,6 +17,9 @@
 
 /* written by Jim Meyering */
 
+#ifndef _GL_HEADER_OPENAT_PRIV
+#define _GL_HEADER_OPENAT_PRIV
+
 #include <errno.h>
 #include <stdlib.h>
 
@@ -32,3 +35,5 @@ char *openat_proc_name (char buf[OPENAT_BUFFER_SIZE], int fd, char const *file);
    || (Errno) == EPERM || (Errno) == EACCES    \
    || (Errno) == ENOSYS /* Solaris 8 */                \
    || (Errno) == EOPNOTSUPP /* FreeBSD */)
+
+#endif /* _GL_HEADER_OPENAT_PRIV */

diff --git a/lib/symlinkat.c b/lib/symlinkat.c
index 6fe752f14aca86dbf6a57671553f5a67637486ed..fd129ea014054113fcc3df2239bb117e44df29f9 100644 (file)
--- a/lib/symlinkat.c
+++ b/lib/symlinkat.c
@@ -20,11 +20,6 @@
 
 #include <unistd.h>
 
-#include "dirname.h" /* solely for definition of IS_ABSOLUTE_FILE_NAME */
-#include "openat.h"
-#include "openat-priv.h"
-#include "save-cwd.h"
-
 #if !HAVE_SYMLINK
 /* Mingw lacks symlink, so this wrapper is trivial.  */