fts: don't operate on an invalid file descriptor after failed dup

* lib/fts.c (fts_build): Don't call set_cloexec_flag on a
negative file descriptor.

diff --git a/ChangeLog b/ChangeLog
index 8e6c3c23b44a3bbd458045c36e9d2fdf168be9e0..9910da220e449575ba85c09c7a304bf7f1a60518 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-09-13  Jim Meyering  <meyering@redhat.com>
+
+       fts: don't operate on an invalid file descriptor after failed dup
+       * lib/fts.c (fts_build): Don't call set_cloexec_flag on a
+       negative file descriptor.
+
 2010-09-12  Paul Eggert  <eggert@cs.ucla.edu>
 
        savedir: add streamsavedir, deprecate fdsavedir

diff --git a/lib/fts.c b/lib/fts.c
index a308a8c94e88bfbd6089412053f5c6c526214f5f..4b89ee780b743c86aad31787386c6059830e9066 100644 (file)
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1305,7 +1305,8 @@ fts_build (register FTS *sp, int type)
                 if (ISSET(FTS_CWDFD) && 0 <= dir_fd)
                   {
                     dir_fd = dup (dir_fd);
-                    set_cloexec_flag (dir_fd, true);
+                    if (0 <= dir_fd)
+                      set_cloexec_flag (dir_fd, true);
                   }
                 if (dir_fd < 0 || fts_safe_changedir(sp, cur, dir_fd, NULL)) {
                         if (nlinks && type == BREAD)