posixtm.c: avoid a warning

* lib/posixtm.c (posixtime): Don't initialize tm0.
It's no longer needed to placate gcc4's -Wuninitialized,
and the attempt to placate would elicit a new warning.

diff --git a/ChangeLog b/ChangeLog
index 2865b547e16c864eb1d85b4d1683a69ba52a3dc4..5f11392c77515c44877144d44d3c31b560f97f25 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-12-07  Jim Meyering  <meyering@redhat.com>
 
+       posixtm.c: avoid a warning
+       * lib/posixtm.c (posixtime): Don't initialize tm0.
+       It's no longer needed to placate gcc4's -Wuninitialized,
+       and the attempt to placate would elicit a new warning.
+
        unicodeio.c: mark unused parameters
        * lib/unicodeio.c (exit_failure_callback): Mark unused parameter.
        (fallback_failure_callback): Likewise.

diff --git a/lib/posixtm.c b/lib/posixtm.c
index fff53f50b95bac8df3f651e2539f2f761f0e4589..7740f4d9da2d6558955200a147f8ad14fa6d43d6 100644 (file)
--- a/lib/posixtm.c
+++ b/lib/posixtm.c
@@ -186,15 +186,7 @@ posix_time_parse (struct tm *tm, const char *s, unsigned int syntax_bits)
 bool
 posixtime (time_t *p, const char *s, unsigned int syntax_bits)
 {
-  struct tm tm0
-#ifdef lint
-  /* Placate gcc-4's -Wuninitialized.
-     posix_time_parse fails to set all of tm0 only when it returns
-     nonzero (due to year() returning nonzero), and in that case,
-     this code doesn't use the tm0 at all.  */
-    = { 0, }
-#endif
-    ;
+  struct tm tm0;
   struct tm tm1;
   struct tm const *tm;
   time_t t;