dpif: Rename dpif_get_name() to dpif_port_get_name(), update interface.

With multiple kinds of datapaths, code should not just use
"dp%u" along with dpif_minor() to print a datapath name, because not all
datapaths can sensibly be named that way.  We want to use a function
with a name like dpif_get_name() to retrieve a datapath name for printing
to the user, in which case the existing dpif_get_name() function would be
confusing.  So rename the existing one to something more explicit.

diff --git a/lib/dpif.c b/lib/dpif.c
index 21f1173fa8fe132479e1e03255aad9db7a20d0d9..3dc7af00704bb1d703edd3405b65c438cf4338c8 100644 (file)
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -168,22 +168,6 @@ dpif_create(const char *name, struct dpif *dpif)
     }
 }
 
-int
-dpif_get_name(struct dpif *dpif, char *name, size_t name_size)
-{
-    struct odp_port port;
-    int error;
-
-    assert(name_size > 0);
-    *name = '\0';
-
-    error = dpif_port_query_by_number(dpif, ODPP_LOCAL, &port);
-    if (!error) {
-        ovs_strlcpy(name, port.devname, name_size);
-    }
-    return error;
-}
-
 int
 dpif_delete(struct dpif *dpif)
 {
@@ -322,6 +306,24 @@ dpif_port_query_by_name(const struct dpif *dpif, const char *devname,
     }
 }
 
+int
+dpif_port_get_name(struct dpif *dpif, uint16_t port_no,
+                   char *name, size_t name_size)
+{
+    struct odp_port port;
+    int error;
+
+    assert(name_size > 0);
+
+    error = dpif_port_query_by_number(dpif, port_no, &port);
+    if (!error) {
+        ovs_strlcpy(name, port.devname, name_size);
+    } else {
+        *name = '\0';
+    }
+    return error;
+}
+
 int
 dpif_port_list(const struct dpif *dpif,
                struct odp_port **ports, size_t *n_ports)
@@ -698,7 +700,8 @@ dpifmon_create(const char *datapath_name, struct dpifmon **monp)
     if (error) {
         goto error;
     }
-    error = dpif_get_name(&mon->dpif, local_name, sizeof local_name);
+    error = dpif_port_get_name(&mon->dpif, ODPP_LOCAL,
+                               local_name, sizeof local_name);
     if (error) {
         goto error_close_dpif;
     }

diff --git a/lib/dpif.h b/lib/dpif.h
index d81cf631e4cb2abeb41a3e47d854d487e7e7ab5b..a0e603114a146e1fd2e277c39e405650a416cad6 100644 (file)
--- a/lib/dpif.h
+++ b/lib/dpif.h
@@ -40,7 +40,6 @@ int dpif_create(const char *name, struct dpif *);
 void dpif_close(struct dpif *);
 
 static inline unsigned int dpif_id(const struct dpif *dpif);
-int dpif_get_name(struct dpif *, char *name, size_t name_size);
 
 int dpif_delete(struct dpif *);
 
@@ -59,6 +58,8 @@ int dpif_port_query_by_number(const struct dpif *, uint16_t port_no,
                               struct odp_port *);
 int dpif_port_query_by_name(const struct dpif *, const char *devname,
                             struct odp_port *);
+int dpif_port_get_name(struct dpif *, uint16_t port_no,
+                       char *name, size_t name_size);
 int dpif_port_list(const struct dpif *, struct odp_port **, size_t *n_ports);
 
 int dpif_port_group_set(struct dpif *, uint16_t group,

diff --git a/secchan/discovery.c b/secchan/discovery.c
index 0c08de392a5471dc88d94780d1b88f0441a0a074..2868db5a8599f4b895385b8ac8e0b59695497d99 100644 (file)
--- a/secchan/discovery.c
+++ b/secchan/discovery.c
@@ -112,7 +112,8 @@ discovery_create(const char *re, bool update_resolv_conf,
     d->update_resolv_conf = update_resolv_conf;
 
     /* Initialize DHCP client. */
-    error = dpif_get_name(dpif, local_name, sizeof local_name);
+    error = dpif_port_get_name(dpif, ODPP_LOCAL,
+                               local_name, sizeof local_name);
     if (error) {
         VLOG_ERR("failed to query datapath local port: %s", strerror(error));
         goto error_regfree;

diff --git a/secchan/in-band.c b/secchan/in-band.c
index 9dccf5f1586b0f11883980b1720cefd0ed519c52..1e242385488179cc84c401978a39f124e2370907 100644 (file)
--- a/secchan/in-band.c
+++ b/secchan/in-band.c
@@ -321,7 +321,8 @@ in_band_create(struct ofproto *ofproto,
     int error;
 
     *in_bandp = NULL;
-    error = dpif_get_name(dpif, local_name, sizeof local_name);
+    error = dpif_port_get_name(dpif, ODPP_LOCAL,
+                               local_name, sizeof local_name);
     if (error) {
         return error;
     }

diff --git a/secchan/ofproto.c b/secchan/ofproto.c
index aa9e44a1baef453773098260975f1687918c5f84..8cde9bfe816751f39a3f113fb39debd0656dbd15 100644 (file)
--- a/secchan/ofproto.c
+++ b/secchan/ofproto.c
@@ -3233,7 +3233,8 @@ pick_datapath_id(struct dpif *dpif, uint64_t fallback_dpid)
     uint8_t ea[ETH_ADDR_LEN];
     int error;
 
-    error = dpif_get_name(dpif, local_name, sizeof local_name);
+    error = dpif_port_get_name(dpif, ODPP_LOCAL,
+                               local_name, sizeof local_name);
     if (!error) {
         error = netdev_nodev_get_etheraddr(local_name, ea);
         if (!error) {

diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 583e5548bca1f25021fa8000bbd220de8551e4c5..254aa9579650a7cfbccaba9c98bb7e7839fba055 100644 (file)
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -268,7 +268,7 @@ open_vconn(const char *name, struct vconn **vconnp)
         char *socket_name;
         char *vconn_name;
 
-        run(dpif_get_name(&dpif, dpif_name, sizeof dpif_name),
+        run(dpif_port_get_name(&dpif, ODPP_LOCAL, dpif_name, sizeof dpif_name),
             "obtaining name of %s", dpif_name);
         dpif_close(&dpif);
         if (strcmp(dpif_name, name)) {

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index ba9052872a70325a260dd82f938496d773a50cb6..7ecf12458f2a2a9380e0a0d04a20e90dccc7be03 100644 (file)
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -288,7 +288,8 @@ bridge_init(void)
         retval = dpif_open(devname, &dpif);
         if (!retval) {
             char dpif_name[IF_NAMESIZE];
-            if (dpif_get_name(&dpif, dpif_name, sizeof dpif_name)
+            if (dpif_port_get_name(&dpif, ODPP_LOCAL,
+                                   dpif_name, sizeof dpif_name)
                 || !cfg_has("bridge.%s.port", dpif_name)) {
                 dpif_delete(&dpif);
             }