Add some comments.

diff --git a/ChangeLog b/ChangeLog
index 391bb3f5757ce3335cc4b86ac8c9c09cd5b21df6..dfd8ca3ad4a655850d994478685787f117a5e9c3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-04-27  Bruno Haible  <bruno@clisp.org>
+
+       * lib/rpmatch.c (rpmatch): Add some comments.
+       Reported by James Youngman <jay@gnu.org>.
+
 2008-04-27  Bruno Haible  <bruno@clisp.org>
 
        * m4/isnanl.m4 (gl_FUNC_ISNANL_WORKS): Also test the behaviour on

diff --git a/lib/rpmatch.c b/lib/rpmatch.c
index 826bc4c5e5244970bbbae96c273dabd2030bd5a9..f1b7071fd8b0dcb3076653985b0cc7c692c421be 100644 (file)
--- a/lib/rpmatch.c
+++ b/lib/rpmatch.c
@@ -1,7 +1,7 @@
 /* Determine whether string value is affirmation or negative response
    according to current locale's data.
 
-   Copyright (C) 1996, 1998, 2000, 2002, 2003, 2006 Free Software
+   Copyright (C) 1996, 1998, 2000, 2002, 2003, 2006, 2008 Free Software
    Foundation, Inc.
 
    This program is free software: you can redistribute it and/or modify
@@ -61,6 +61,15 @@ rpmatch (const char *response)
   /* Match against one of the response patterns, compiling the pattern
      first if necessary.  */
 
+  /* We get the patterns from a PO file.  It would be possible to use
+     nl_langinfo (YESEXPR) instead of _("^[yY]"), and nl_langinfo (NOEXPR)
+     instead of _("^[nN]"), if we could assume that the system's locale
+     support is good.  But this is not the case e.g. on Cygwin.  The
+     localizations of gnulib.pot are of better quality in general.
+     Also, if we used locale info from non-free systems that don't have a
+     'localedef' command, we would deprive the users of the freedom to
+     localize this pattern for their preferred language.  */
+
   /* We cache the response patterns and compiled regexps here.  */
   static const char *yesexpr, *noexpr;
   static regex_t yesre, nore;