Move more flags to lib/fcntl.in.h.

* lib/cloexec.c: Do not define FD_CLOEXEC here.
* lib/popen-safer.c: Do not alias O_NOINHERIT to O_CLOEXEC here.
* lib/fcntl.in.h: Do both things here.

diff --git a/ChangeLog b/ChangeLog
index 8210003cfd95d052121490400c3836b797d458d0..a1b015d03029b857c7b0ae7c405b5438c64de190 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-08-21  Paolo Bonzini  <bonzini@gnu.org>
+
+       fcntl: move more flags to the header
+       * lib/cloexec.c: Do not define FD_CLOEXEC here.
+       * lib/popen-safer.c: Do not alias O_NOINHERIT to O_CLOEXEC here.
+       * lib/fcntl.in.h: Do both things here.
+
 2009-08-21  Jim Meyering  <meyering@redhat.com>
 
        consistently remove $@-t before redirecting to it

diff --git a/lib/cloexec.c b/lib/cloexec.c
index ff8105ba024bd8f04a88ece81dd2cca3b6f8d95b..0fb227c0a23e504e5cfa45e2a0c376745dba8669 100644 (file)
--- a/lib/cloexec.c
+++ b/lib/cloexec.c
@@ -24,10 +24,6 @@
 #include <unistd.h>
 #include <fcntl.h>
 
-#ifndef FD_CLOEXEC
-# define FD_CLOEXEC 1
-#endif
-
 /* Set the `FD_CLOEXEC' flag of DESC if VALUE is true,
    or clear the flag if VALUE is false.
    Return 0 on success, or -1 on error with `errno' set. */

diff --git a/lib/fcntl.in.h b/lib/fcntl.in.h
index fd7520e8daed331481fdaea90c375176ee314b2e..a688fb4bbf77f9d02ed601a3d374b3943b2a12a5 100644 (file)
--- a/lib/fcntl.in.h
+++ b/lib/fcntl.in.h
@@ -67,6 +67,11 @@ extern void _gl_register_fd (int fd, const char *filename);
 }
 #endif
 
+/* Fix up the FD_* macros.  */
+
+#ifndef FD_CLOEXEC
+# define FD_CLOEXEC 1
+#endif
 
 /* Fix up the O_* macros.  */
 
@@ -75,6 +80,12 @@ extern void _gl_register_fd (int fd, const char *filename);
 # define O_DIRECT O_DIRECTIO
 #endif
 
+#if !defined O_CLOEXEC && defined O_NOINHERIT
+/* Mingw spells it `O_NOINHERIT'.  Intentionally leave it
+   undefined if not available.  */
+# define O_CLOEXEC O_NOINHERIT
+#endif
+
 #ifndef O_DIRECT
 # define O_DIRECT 0
 #endif

diff --git a/lib/popen-safer.c b/lib/popen-safer.c
index 2182a2c03c6a88f8f9d9a9d17e7713bc21bf61d4..1905be5ecbf898b079255f63d4629490a0d33b8e 100644 (file)
--- a/lib/popen-safer.c
+++ b/lib/popen-safer.c
@@ -27,9 +27,7 @@
 
 #include "cloexec.h"
 
-#if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
-# define O_CLOEXEC O_NOINHERIT
-#elif !defined O_CLOEXEC
+#ifndef O_CLOEXEC
 # define O_CLOEXEC 0
 #endif