Remove unnecessary check for validity when dereferencing an array.

Thanks to Masa et al. for pointing this out.

diff --git a/switch/datapath.c b/switch/datapath.c
index 9ec768d62f896a98dd45ccbd16755b4bb96d690a..4321f94fddb27cd71b9f3327e3f4ea4e3a0e82cb 100644 (file)
--- a/switch/datapath.c
+++ b/switch/datapath.c
@@ -686,7 +686,7 @@ dp_update_port_flags(struct datapath *dp, const struct ofp_port_mod *opm)
         struct sw_port *p = &dp->ports[port_no];
 
         /* Make sure the port id hasn't changed since this was sent */
-        if (!p || memcmp(opm->hw_addr, netdev_get_etheraddr(p->netdev),
+        if (memcmp(opm->hw_addr, netdev_get_etheraddr(p->netdev),
                          ETH_ADDR_LEN) != 0) {
             return;
         }