pread: improvement and fix

* modules/pread (Depends-on): Depend on lseek, for portability to
e.g., mingw.  Suggested by Eric Blake.
* lib/pread.c (__libc_read): Define.  Reported by Richard W.M. Jones.

diff --git a/ChangeLog b/ChangeLog
index 6128785ab9a21eb1e4f7bcab9d6f0bccb5fc4879..2e5f9fbe61f2f92f8533e8f841393236969d53d5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2009-11-25  Jim Meyering  <meyering@redhat.com>
 
+       pread: improvement and fix
+       * modules/pread (Depends-on): Depend on lseek, for portability to
+       e.g., mingw.  Suggested by Eric Blake.
+       * lib/pread.c (__libc_read): Define.  Reported by Richard W.M. Jones.
+
        unistd.in.h: correct declaration of pread
        * lib/unistd.in.h: Correct type of "buf" parameter: void*, not char*
        Reported by Richard W.M. Jones.

diff --git a/lib/pread.c b/lib/pread.c
index 632b91497c77b3cea71e35fe028f7963178e7df0..7094ea7d087c32fb9d963b312b8d9a93649a8056 100644 (file)
--- a/lib/pread.c
+++ b/lib/pread.c
@@ -23,6 +23,7 @@
 
 #define __libc_lseek(f,o,w) lseek (f, o, w)
 #define __set_errno(Val) errno = (Val)
+#define __libc_read(f,b,n) read (f, b, n)
 
 /* pread substitute for systems that the function, such as mingw32 and BeOS.  */
 /* The following is identical to the function from glibc's

diff --git a/modules/pread b/modules/pread
index 06039e64dd66cb0cf1a161ae738a527b9c369e76..4fb442467fc99a34cb5075d79e98bd0add4b3d3a 100644 (file)
--- a/modules/pread
+++ b/modules/pread
@@ -6,6 +6,7 @@ lib/pread.c
 m4/pread.m4
 
 Depends-on:
+lseek
 unistd
 
 configure.ac: