projects
/
openvswitch
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6915562
)
datapath: When adding a port, return the new port number to userspace.
author
Ben Pfaff
<blp@nicira.com>
Thu, 11 Feb 2010 00:53:40 +0000
(16:53 -0800)
committer
Ben Pfaff
<blp@nicira.com>
Thu, 11 Feb 2010 00:54:48 +0000
(16:54 -0800)
'port' is a kernel-space copy of the odp_port and modifying it is useless.
'portp' is the userspace copy; modifying it is useful.
None of our current userspace users care about the port number and so we
never noticed.
Found by sparse (http://sparse.wiki.kernel.org/).
datapath/datapath.c
patch
|
blob
|
history
diff --git
a/datapath/datapath.c
b/datapath/datapath.c
index ba363fb779f03a12bc37344ad8ddc3874b558446..94f31969090ede688aa850a14b708cf619fb99dc 100644
(file)
--- a/
datapath/datapath.c
+++ b/
datapath/datapath.c
@@
-422,7
+422,7
@@
got_port_no:
dp_sysfs_add_if(dp->ports[port_no]);
- err = __put_user(port_no, &port
.
port);
+ err = __put_user(port_no, &port
p->
port);
out_put:
dev_put(dev);