Fix potential null pointer dereference
authorJohn Darrington <john@darrington.wattle.id.au>
Fri, 12 Aug 2016 04:53:35 +0000 (06:53 +0200)
committerJohn Darrington <john@darrington.wattle.id.au>
Fri, 12 Aug 2016 04:53:35 +0000 (06:53 +0200)
Found by cppcheck

src/ui/gui/psppire-dict.c

index b88bbe7766300a6a110bd211902c5e5aa95691c7..0ee608cadef083eacb9f770aecfb37ff9d32af72 100644 (file)
@@ -680,11 +680,11 @@ tree_model_iter_next (GtkTreeModel *model, GtkTreeIter *iter)
   struct variable *var;
   gint idx;
 
-  g_return_val_if_fail (iter->stamp == dict->stamp, FALSE);
-
   if ( iter == NULL || iter->user_data == NULL)
     return FALSE;
 
+  g_return_val_if_fail (iter->stamp == dict->stamp, FALSE);
+
   var = iter->user_data;
 
   idx = var_get_dict_index (var);