Make xnanosleep's integer overflow test more robust.

* lib/xnanosleep.c (xnanosleep): Declare a temporary to be "volatile",
so that gcc-4.3.0 doesn't optimize away this test for overflow.

Signed-off-by: Jim Meyering <meyering@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 7401df0282480112d0c23e71d43353dfe12bfa93..275e2ed5e2ee163c68fe002a2d547f1b9fa8bdf9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2007-10-07  Jim Meyering  <meyering@redhat.com>
+
+       Make xnanosleep's integer overflow test more robust.
+       * lib/xnanosleep.c (xnanosleep): Declare a temporary to be "volatile",
+       so that gcc-4.3.0 doesn't optimize away this test for overflow.
+
 2007-10-07  Bruno Haible  <bruno@clisp.org>
 
        * doc/gnulib-intro.texi (Copyright): Update the meaning of the license

diff --git a/lib/xnanosleep.c b/lib/xnanosleep.c
index 6a61ddb0c3359b805b05a1a35eba05d7bbb44730..22bd53a953fc2a4a68bc5db2e34be7ce7553253d 100644 (file)
--- a/lib/xnanosleep.c
+++ b/lib/xnanosleep.c
@@ -72,7 +72,9 @@ xnanosleep (double seconds)
   /* Normalize the interval length.  nanosleep requires this.  */
   if (BILLION <= ts_sleep.tv_nsec)
     {
-      time_t t = ts_sleep.tv_sec + 1;
+      /* Declare "volatile" so that gcc-4.3.0 doesn't optimize away
+        the overflow test.  */
+      volatile time_t t = ts_sleep.tv_sec + 1;
 
       /* Detect integer overflow.  */
       overflow |= (t < ts_sleep.tv_sec);