fts: tweak inode comparison function

* lib/fts.c (fts_compare_ino): Sort on increasing, not decreasing
inode numbers, as documented.

SCALAR(0xeb1b20)

diff --git a/ChangeLog b/ChangeLog
index db626d3d09d6efbcedfbb8509b96928a59b0a0ad..2ee1db36e75ac7266084ca5defe8afe13725bfae 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2008-09-26  Jim Meyering  <meyering@redhat.com>
 
+       fts: tweak inode comparison function
+       * lib/fts.c (fts_compare_ino): Sort on increasing, not decreasing
+       inode numbers, as documented.
+
        fts: sort dirent entries on inode number before traversing
        This avoids a quadratic, seek-related performance penalty when
        operating on a directory containing many entries (measurable at 10k;
@@ -12,6 +16,7 @@
        (dirent_inode_sort_may_be_useful, fts_compare_ino): Likewise.
        (fts_build): Set the stat.st_ino member from D_INO.
        If it is likely to be useful, sort dirent entries on inode number.
+
        * m4/fts.m4 (gl_FUNC_FTS_CORE): Check for fstatfs, sys/vfs.h,
        and the struct statfs.f_type member.
        * modules/fts (Depends-on): Add d-ino.

diff --git a/lib/fts.c b/lib/fts.c
index 3cf49fa839f3b6f4121f3f58dad2fb1b8329c24c..673693a67175a42ee2fe133ea7cdf5a132be4d38 100644 (file)
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -981,8 +981,8 @@ static bool dirent_inode_sort_may_be_useful (FTS const *sp) { return true; }
 static int
 fts_compare_ino (struct _ftsent const **a, struct _ftsent const **b)
 {
-  return (a[0]->fts_statp->st_ino < b[0]->fts_statp->st_ino ? 1
-         : b[0]->fts_statp->st_ino < a[0]->fts_statp->st_ino ? -1 : 0);
+  return (a[0]->fts_statp->st_ino < b[0]->fts_statp->st_ino ? -1
+         : b[0]->fts_statp->st_ino < a[0]->fts_statp->st_ino ? 1 : 0);
 }
 
 /*