open: fix opening directory on mingw

open(".",O_WRONLY) used uninitialized memory to decide whether
to succeed or fail - never a good idea ;)

* lib/open.c (open) [REPLACE_OPEN_DIRECTORY]: Correct typo.

Signed-off-by: Eric Blake <ebb9@byu.net>

diff --git a/ChangeLog b/ChangeLog
index 3ef349e998613da93bc3fa311f7429d6b9f55df7..df080c8bb18952a08b9f53be8299b6c716e769c5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2009-10-02  Eric Blake  <ebb9@byu.net>
 
+       open: fix opening directory on mingw
+       * lib/open.c (open) [REPLACE_OPEN_DIRECTORY]: Correct typo.
+
        test-open: on GNU/Hurd, /dev/null is a directory
        * tests/test-fopen.h (main): Rename...
        (test_fopen): ...to this.  Use a guaranteed non-directory when

diff --git a/lib/open.c b/lib/open.c
index 7cc25bd07c9511f94b87fce85c442d35e5fb92b0..8027b473a5a385816248b638a486abce5071aaf5 100644 (file)
--- a/lib/open.c
+++ b/lib/open.c
@@ -111,7 +111,7 @@ open (const char *filename, int flags, ...)
      override fstat() in fchdir.c to hide the fact that we have a
      dummy.  */
   if (REPLACE_OPEN_DIRECTORY && fd < 0 && errno == EACCES
-      && (mode & O_ACCMODE) == O_RDONLY)
+      && (flags & O_ACCMODE) == O_RDONLY)
     {
       struct stat statbuf;
       if (stat (filename, &statbuf) == 0 && S_ISDIR (statbuf.st_mode))