fprintftime: avoid a warning about ignored fwrite return value

* lib/strftime.c [FPRINTFTIME]: Include "ignore-value.h".
(cpy) [FPRINTFTIME]: Ignore fwrite failure, even though technically,
that is unsafe.
* modules/fprintftime (Depends-on): Add ignore-value.

diff --git a/ChangeLog b/ChangeLog
index 54a79e86ed7df524b536cf8fa94ac04823650298..ed3e6bd1240bfdbf54ed7526797574049dff5922 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2009-10-28  Jim Meyering  <meyering@redhat.com>
 
+       fprintftime: avoid a warning about ignored fwrite return value
+       * lib/strftime.c [FPRINTFTIME]: Include "ignore-value.h".
+       (cpy) [FPRINTFTIME]: Ignore fwrite failure, even though technically,
+       that is unsafe.
+       * modules/fprintftime (Depends-on): Add ignore-value.
+
        exclude: avoid an unwarranted warning
        * lib/exclude.c (excluded_file_name): Initialize "rc" before switch.
 

diff --git a/lib/strftime.c b/lib/strftime.c
index fff5d38eaeca6ce298e8d1f03431713a17bfb654..7f06d6fda24d6a89090b1b4f3b482a7966845907 100644 (file)
--- a/lib/strftime.c
+++ b/lib/strftime.c
@@ -31,6 +31,7 @@
 # else
 #  include "strftime.h"
 # endif
+# include "ignore-value.h"
 #endif
 
 #include <ctype.h>
@@ -203,7 +204,15 @@ extern char *tzname[];
         else if (to_uppcase)                                                 \
           fwrite_uppcase (p, (s), _n);                                       \
         else                                                                 \
-          fwrite ((s), _n, 1, p))
+          {                                                                  \
+            /* We are ignoring the value of fwrite here, in spite of the     \
+               fact that technically, that may not be valid: the fwrite      \
+               specification in POSIX 2008 defers to that of fputc, which    \
+               is intended to be consistent with the one from ISO C,         \
+               which permits failure due to ENOMEM *without* setting the     \
+               stream's error indicator.  */                                 \
+            ignore_value (fwrite ((s), _n, 1, p)));                          \
+          }
 #else
 # define cpy(n, s)                                                           \
     add ((n),                                                                \

diff --git a/modules/fprintftime b/modules/fprintftime
index 4333a31374f1edfa8ae5acf927cc6bc62ecb89f8..87598eff1856db3cd6ec9cbde43ab9231a57eb6f 100644 (file)
--- a/modules/fprintftime
+++ b/modules/fprintftime
@@ -7,6 +7,7 @@ lib/fprintftime.c
 m4/fprintftime.m4
 
 Depends-on:
+ignore-value
 strftime
 
 configure.ac: