PsppireDataEditor: No longer keep a reference to the data window.
authorJohn Darrington <john@darrington.wattle.id.au>
Tue, 10 Jul 2012 16:41:31 +0000 (18:41 +0200)
committerJohn Darrington <john@darrington.wattle.id.au>
Tue, 10 Jul 2012 16:41:31 +0000 (18:41 +0200)
src/ui/gui/psppire-data-editor.c

index aae43698ac75bdfd5c96213e9937aeb1167bb64d..02ef97a9077b1907958a867c611e419751c942b9 100644 (file)
@@ -89,7 +89,6 @@ psppire_data_editor_dispose (GObject *obj)
   if (de->dispose_has_run)
     return;
 
-  g_object_unref (de->data_window);
   g_object_unref (de->data_store);
   g_object_unref (de->var_store);
 
@@ -385,10 +384,9 @@ psppire_data_editor_set_property (GObject         *object,
       psppire_data_editor_split_window (de, g_value_get_boolean (value));
       break;
     case PROP_DATA_WINDOW:
-      if (de->data_window)
-        g_object_unref (de->data_window);
+      /* We hold no reference to this object, since it is used only by do_sort,
+       and that cannot be called unless the window is realized. */
       de->data_window = g_value_get_pointer (value);
-      g_object_ref (de->data_window);
       break;
     case PROP_DATA_STORE:
       if ( de->data_store) g_object_unref (de->data_store);