dup2: work around Haiku bug

dup2(n,n) must be a no-op, but on Haiku, it resets FD_CLOEXEC.
However, we must keep the Linux workaround for dup2(n,n)
returning (unsigned int)-EBADF.

* m4/dup2.m4 (gl_FUNC_DUP2): Test for bug.
* lib/dup2.c (rpl_dup2) [!WIN32]: Add workaround.
* doc/posix-functions/dup2.texi (dup2): Document the bug.
* tests/test-dup2.c (main): Enhance test.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 360f0dd3ca0dc8e0660b4c2a2e2863503dcd72a3..b0254540a6f5edce3a09dec637e3b61e68580d19 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-01-31  Eric Blake  <eblake@redhat.com>
+
+       dup2: work around Haiku bug
+       * m4/dup2.m4 (gl_FUNC_DUP2): Test for bug.
+       * lib/dup2.c (rpl_dup2) [!WIN32]: Add workaround.
+       * doc/posix-functions/dup2.texi (dup2): Document the bug.
+       * tests/test-dup2.c (main): Enhance test.
+
 2011-01-31  Simon Josefsson  <simon@josefsson.org>
 
        doc: off_t is not available in eglibc 2.11.2 stdio.h.

diff --git a/doc/posix-functions/dup2.texi b/doc/posix-functions/dup2.texi
index 59bad08f802070b3f0314f1bc084c7f678c46b44..fc1e3595a9e79b9de55b41f088d055c701a405f4 100644 (file)
--- a/doc/posix-functions/dup2.texi
+++ b/doc/posix-functions/dup2.texi
@@ -16,6 +16,11 @@ mingw.
 This function can hang when duplicating an fd to itself on some platforms:
 mingw.
 
+@item
+This function resets the @code{FD_CLOEXEC} flag when duplicating an fd
+to itself on some platforms:
+Haiku.
+
 @item
 This function returns 0 for @code{dup2 (1, 1)} on some platforms:
 Cygwin 1.5.x.

diff --git a/lib/dup2.c b/lib/dup2.c
index 6b72f7b73f6496894f01c8d68f109b9572b95eee..e00dc7b2e3c5f2789bc6a578a5f45be67871a2ef 100644 (file)
--- a/lib/dup2.c
+++ b/lib/dup2.c
@@ -59,6 +59,10 @@ rpl_dup2 (int fd, int desired_fd)
       errno = EBADF;
       return -1;
     }
+# elif !defined __linux__
+  /* On Haiku, dup2 (fd, fd) mistakenly clears FD_CLOEXEC.  */
+  if (fd == desired_fd)
+    return fcntl (fd, F_GETFL) == -1 ? -1 : fd;
 # endif
   result = dup2 (fd, desired_fd);
 # ifdef __linux__

diff --git a/m4/dup2.m4 b/m4/dup2.m4
index bc2f417fd3bb3cedc4310e2757cc86c021bfa7cd..def263b87a85b7ccd38e0c539f894718817a75c9 100644 (file)
--- a/m4/dup2.m4
+++ b/m4/dup2.m4
@@ -1,4 +1,4 @@
-#serial 11
+#serial 12
 dnl Copyright (C) 2002, 2005, 2007, 2009-2011 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -8,7 +8,7 @@ AC_DEFUN([gl_FUNC_DUP2],
 [
   AC_REQUIRE([gl_UNISTD_H_DEFAULTS])
   AC_REQUIRE([AC_CANONICAL_HOST])
-  AC_CHECK_FUNCS_ONCE([dup2])
+  AC_CHECK_FUNCS_ONCE([dup2 fcntl])
   if test $ac_cv_func_dup2 = no; then
     HAVE_DUP2=0
     AC_LIBOBJ([dup2])
@@ -16,16 +16,25 @@ AC_DEFUN([gl_FUNC_DUP2],
     AC_CACHE_CHECK([whether dup2 works], [gl_cv_func_dup2_works],
       [AC_RUN_IFELSE([
          AC_LANG_PROGRAM([[#include <unistd.h>
+#include <fcntl.h>
 #include <errno.h>]],
            [int result = 0;
-            if (dup2 (1, 1) == 0)
+#if HAVE_FCNTL
+            if (fcntl (1, F_SETFD, FD_CLOEXEC) == -1)
               result |= 1;
+#endif HAVE_FCNTL
+            if (dup2 (1, 1) == 0)
+              result |= 2;
+#if HAVE_FCNTL
+            if (fcntl (1, F_GETFD) != FD_CLOEXEC)
+              result |= 4;
+#endif
             close (0);
             if (dup2 (0, 0) != -1)
-              result |= 2;
+              result |= 8;
             /* Many gnulib modules require POSIX conformance of EBADF.  */
-            if (dup2 (1, 1000000) == -1 && errno != EBADF)
-              result |= 4;
+            if (dup2 (2, 1000000) == -1 && errno != EBADF)
+              result |= 16;
             return result;
            ])
         ],
@@ -40,6 +49,8 @@ AC_DEFUN([gl_FUNC_DUP2],
              gl_cv_func_dup2_works=no;;
            freebsd*) # on FreeBSD 6.1, dup2(1,1000000) gives EMFILE, not EBADF.
              gl_cv_func_dup2_works=no;;
+           haiku*) # on Haiku alpha 2, dup2(1, 1) resets FD_CLOEXEC.
+             gl_cv_func_dup2_works=no;;
            *) gl_cv_func_dup2_works=yes;;
          esac])
       ])

diff --git a/tests/test-dup2.c b/tests/test-dup2.c
index 35aa6ca474b8f9dd2f5a05267a25eab84f51f78a..e2ad88bccaf217d880e61548211530d2176f9368 100644 (file)
--- a/tests/test-dup2.c
+++ b/tests/test-dup2.c
@@ -169,7 +169,12 @@ main (void)
   ASSERT (dup2 (fd + 1, fd + 1) == fd + 1);
   ASSERT (!is_inheritable (fd + 1));
   ASSERT (dup2 (fd + 1, fd + 2) == fd + 2);
+  ASSERT (!is_inheritable (fd + 1));
   ASSERT (is_inheritable (fd + 2));
+  errno = 0;
+  ASSERT (dup2 (fd + 1, -1) == -1);
+  ASSERT (errno == EBADF);
+  ASSERT (!is_inheritable (fd + 1));
 #endif
 
   /* On systems that distinguish between text and binary mode, dup2